Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use newer attribute client with lazy errors #81

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

aaron-steinfeld
Copy link
Contributor

Description

Use newer attribute client with better performing client (builds errors lazily, less exception filling)

@aaron-steinfeld aaron-steinfeld requested review from avinashkolluru and a team July 22, 2021 18:15
@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #81 (8e70519) into main (1d9d24b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #81   +/-   ##
=========================================
  Coverage     81.62%   81.62%           
  Complexity      391      391           
=========================================
  Files            37       37           
  Lines          1513     1513           
  Branches        162      162           
=========================================
  Hits           1235     1235           
  Misses          205      205           
  Partials         73       73           
Flag Coverage Δ
integration 81.62% <ø> (ø)
unit 79.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d9d24b...8e70519. Read the comment docs.

@github-actions

This comment has been minimized.

@aaron-steinfeld aaron-steinfeld merged commit f184fce into main Jul 22, 2021
@aaron-steinfeld aaron-steinfeld deleted the lazy-attribute-errors branch July 22, 2021 18:23
@github-actions
Copy link

Unit Test Results

  22 files  ±0    22 suites  ±0   8s ⏱️ +2s
113 tests ±0  113 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f184fce. ± Comparison against base commit 1d9d24b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants