Fixed internal error in pinot queries caused due to question mark (?) in query parameter. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n mark (?) in query parameter.
Pinot PreparedStatement creates invalid query if one of the parameters has '?' in its value.
Sample pinot query : `select * from table where team in (?, ?, ?)`..
Now say parameters are: 'abc', 'pqr with (?)' and 'xyz'..
Now, on executing PreparedStatement:fillStatementWithParameters method on this will return
`select * from table where team in ('abc', 'pqr with ('xyz')', ?)`
-- which is clearly wrong
(what we wanted was `select * from table where team in ('abc', 'pqr with (?)', 'xyz')`)..
The reason is the usage of replaceFirst iteration in the pinot PreparedStatement method..
Hence written a custom method to resolve the query statement rather than relying on Pinot's library method.
Also raised an issue in incubator-pinot github repo: apache/pinot#6834
Codecov Report
@@ Coverage Diff @@
## main #73 +/- ##
============================================
- Coverage 81.95% 81.40% -0.56%
Complexity 377 377
============================================
Files 37 37
Lines 1452 1468 +16
Branches 148 151 +3
============================================
+ Hits 1190 1195 +5
- Misses 194 204 +10
- Partials 68 69 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
findingrish
reviewed
Apr 23, 2021
...y-service-impl/src/main/java/org/hypertrace/core/query/service/pinot/PinotClientFactory.java
Outdated
Show resolved
Hide resolved
|
nit: jira id can be removed from the description |
singhalprerana
changed the title
...ice-impl/src/main/java/org/hypertrace/core/query/service/pinot/PinotBasedRequestHandler.java
Outdated
Show resolved
Hide resolved
…to pinot/query/fix/question-mark
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| * Hence written this custom method to resolve the query statement rather than relying on Pinot's | ||
| * library method. | ||
| * This is a temporary fix and can be reverted when the Pinot issue gets resolved | ||
| * Raised an issue in incubator-pinot github repo: apache/incubator-pinot#6834 |
jcchavezs
reviewed
Apr 23, 2021
...y-service-impl/src/main/java/org/hypertrace/core/query/service/pinot/PinotClientFactory.java
Show resolved
Hide resolved
jcchavezs
reviewed
Apr 23, 2021
...y-service-impl/src/main/java/org/hypertrace/core/query/service/pinot/PinotClientFactory.java
Outdated
Show resolved
Hide resolved
jcchavezs
reviewed
Apr 23, 2021
...y-service-impl/src/main/java/org/hypertrace/core/query/service/pinot/PinotClientFactory.java
Outdated
Show resolved
Hide resolved
jcchavezs
reviewed
Apr 23, 2021
| * This is a temporary fix and can be reverted when the Pinot issue gets resolved | ||
| * Raised an issue in incubator-pinot github repo: apache/incubator-pinot#6834 | ||
| */ | ||
| String resolveStatement(String query, Params params) { |
There was a problem hiding this comment.
What happens in this method when the number of ? don't match the number of params?
There was a problem hiding this comment.
if number of params are more, we drop the extras and if it's less, we replace ? with empty string.. the loop takes care of this..
jcchavezs
reviewed
Apr 23, 2021
|
|
||
| @VisibleForTesting | ||
| /* | ||
| * Pinot PreparedStatement creates invalid query if one of the parameters has '?' in its value. |
This comment has been minimized.
This comment has been minimized.
avinashkolluru
approved these changes
Apr 24, 2021
findingrish
approved these changes
Apr 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinot PreparedStatement creates invalid query if one of the parameters has '?' in its value.
Sample pinot query :
select * from table where team in (?, ?, ?)..Now say parameters are: 'abc', 'pqr with (?)' and 'xyz'..
Now, on executing PreparedStatement:fillStatementWithParameters method on this will return
select * from table where team in ('abc', 'pqr with ('xyz')', ?)-- which is clearly wrong
(what we wanted was
select * from table where team in ('abc', 'pqr with (?)', 'xyz'))..The reason is the usage of replaceFirst iteration in the pinot PreparedStatement method..
Hence written a custom method to resolve the query statement rather than relying on Pinot's library method.
Also raised an issue in incubator-pinot github repo: apache/pinot#6834