ci: migrating to GitHub actions #47
Conversation
JBAhire
requested review from
avinashkolluru,
buchi-busireddy,
inespo and
tim-mwangi
as code owners
| - name: Setup snyk | ||
| uses: snyk/actions/[email protected] | ||
| - name: Snyk test | ||
| run: snyk test --all-sub-projects --org=hypertrace --severity-threshold=low --policy-path=.snyk --configuration-matching='^runtimeClasspath$' |
There was a problem hiding this comment.
also may be worth moving this into an action at some point
There was a problem hiding this comment.
I think, we can't move this step to action as it's already using other action. let me try this one.
There was a problem hiding this comment.
the setup itself would have to stay out (still crazy to me that GH doesn't support this yet, suspect it must be coming soon), but the test could be its own action right? or we could make the test run in a containerized action which means setup isn't needed
There was a problem hiding this comment.
for this, I would wait as they said they will bring support for uses and if in near future. We would like to abstract this at that time anyways. :)
Let me know if that will be fine. We can surely move test but that's a single command so I won't bother a lot about it.
There was a problem hiding this comment.
Up to you. The problem I'm trying to avoid is that the argument set of this command has evolved over time, and now is mismatched in different repos depending on when their ci was set up. Capturing even the single line in an action avoids that (similar to our checksum action), but perhaps it's stable enough now that it's less of a concern and not worth the effort.
Also, I think using a docker-type action allows us to do everything together and do that abstraction now, but again may be more trouble than it's worth - not sure how complex those actions types are to set up.
| gradle-packages-${{ runner.os }}-${{ github.job }} | ||
| gradle-packages-${{ runner.os }} | ||
|
|
||
| - name: Unit test |
There was a problem hiding this comment.
There is no integration test in this repo?
There was a problem hiding this comment.
Just checked, it's not there.
|
hypertrace/actions#9 addresses all changes required on custom actions side. |
| @@ -0,0 +1,10 @@ | |||
| name: 'Gradle command action' | |||
| inputs: | |||
There was a problem hiding this comment.
Guessing this was here for testing since the workflows are using the common one now
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Unit Test Results 21 files 21 suites 4s ⏱️ Results for commit 0759b48. |
Description
Migrating to GitHub actions from CircleCI as per hypertrace/hypertrace#144