chore: update gradle #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-steinfeld
requested review from
avinashkolluru,
buchi-busireddy,
inespo and
tim-mwangi
as code owners
Merged
Codecov Report
@@ Coverage Diff @@
## main #42 +/- ##
=========================================
Coverage 78.93% 78.93%
Complexity 347 347
=========================================
Files 34 34
Lines 1353 1353
Branches 146 146
=========================================
Hits 1068 1068
Misses 218 218
Partials 67 67
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
JBAhire
approved these changes
Nov 25, 2020
tim-mwangi
reviewed
Nov 25, 2020
| @@ -24,7 +24,7 @@ dependencies { | |||
| } | |||
|
|
|||
| application { | |||
| mainClassName = "org.hypertrace.core.serviceframework.PlatformServiceLauncher" | |||
| mainClass.set("org.hypertrace.core.serviceframework.PlatformServiceLauncher") | |||
There was a problem hiding this comment.
this was just a deprecation that I noticed, the old way would have also worked. In general, gradle is moving to use properties (which support lazy resolution) vs values. Most of our own plugins already use the property syntax.
tim-mwangi
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update gradle to latest version
Testing
Built locally
Checklist: