chore: move to trivy based image scan, removed snyk #187
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #187 +/- ##
==========================================
Coverage 78.80% 78.80%
+ Complexity 898 10 -888
==========================================
Files 80 80
Lines 3651 3651
Branches 419 419
==========================================
Hits 2877 2877
Misses 598 598
Partials 176 176
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This comment has been minimized.
This comment has been minimized.
| @@ -7,26 +7,14 @@ on: | |||
|
|
|||
| jobs: | |||
| test: | |||
| runs-on: ubuntu-20.04 | |||
| runs-on: ubuntu-22.04 | |||
There was a problem hiding this comment.
consider consolidating test and build into a single workflow. Example:
https://github.com/hypertrace/service-framework/pull/70/files
There was a problem hiding this comment.
Sure. Will merge them in separate PR.
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Went through the view gen PR to give some suggestions on tacking suppressions an constraints - posting them here too in case helpful hypertrace/view-generator-framework#75 (comment) |
This comment has been minimized.
This comment has been minimized.
| implementation("org.apache.calcite:calcite-babel:1.34.0") { | ||
| because("CVE-2022-39135") | ||
| } | ||
| implementation("org.apache.avro:avro:1.11.1") { |
There was a problem hiding this comment.
There's a number of high-risk upgrades in here. Avro, snakeyaml major version etc. Assuming the direct dep hasn't upgraded, make sure to test at runtime thoroughly if you haven't already
There was a problem hiding this comment.
will verify them
There was a problem hiding this comment.
Validated on saas-dev-sanbox. Query service came up fine. No error in logs when UI is accessed. UI was loading up fine as well.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
As part of this PR:
Adding build to validate image using trivy
Removed snyk steps
Updates few action version
Removed explicit caching step