chore: make like operator query to be case insensitive #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #177 +/- ##
=========================================
Coverage 78.53% 78.53%
Complexity 854 854
=========================================
Files 80 80
Lines 3597 3597
Branches 406 406
=========================================
Hits 2825 2825
Misses 597 597
Partials 175 175
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This comment has been minimized.
This comment has been minimized.
| @@ -33,7 +33,7 @@ | |||
| class DefaultColumnRequestConverter implements ColumnRequestConverter { | |||
|
|
|||
| private static final String QUESTION_MARK = "?"; | |||
| private static final String REGEX_OPERATOR = "~"; | |||
| private static final String REGEX_OPERATOR = "~*"; | |||
There was a problem hiding this comment.
Not that it's relevant, but I wouldn't expect this to be case insensitive. What is relevant is - what is our pinot implementation? They need to match.
There was a problem hiding this comment.
The search is case insensitive in Pinot. Just aligning the implementation.
aaron-steinfeld
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.