-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for distinct count function for array column in postgres #174
Conversation
Codecov Report
@@ Coverage Diff @@
## main #174 +/- ##
============================================
+ Coverage 77.13% 78.52% +1.39%
- Complexity 784 853 +69
============================================
Files 79 80 +1
Lines 3420 3595 +175
Branches 392 405 +13
============================================
+ Hits 2638 2823 +185
+ Misses 608 597 -11
- Partials 174 175 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
For the integration test, it seems some client libs to pinot or something has changed that might be causing it to fail. We may have to pull the latest images to local and need to try.
|
...-impl/src/main/java/org/hypertrace/core/query/service/multivalue/FunctionTransformation.java
Outdated
Show resolved
Hide resolved
…ile doing unnest operation
.../java/org/hypertrace/core/query/service/postgres/QueryRequestToPostgresSQLConverterTest.java
Show resolved
Hide resolved
.../java/org/hypertrace/core/query/service/postgres/QueryRequestToPostgresSQLConverterTest.java
Outdated
Show resolved
Hide resolved
.../java/org/hypertrace/core/query/service/postgres/QueryRequestToPostgresSQLConverterTest.java
Show resolved
Hide resolved
this.resolvedOrderByDescBool = new ArrayList<>(); | ||
} | ||
|
||
public ExecutionContext getExecutionContext() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is lombok part of the buid? if, yes, can we replace it with pre-processor annotation?
...ain/java/org/hypertrace/core/query/service/postgres/converters/PostgresExecutionContext.java
Outdated
Show resolved
Hide resolved
...main/java/org/hypertrace/core/query/service/postgres/QueryRequestToPostgresSQLConverter.java
Outdated
Show resolved
Hide resolved
...main/java/org/hypertrace/core/query/service/postgres/QueryRequestToPostgresSQLConverter.java
Outdated
Show resolved
Hide resolved
...a/org/hypertrace/core/query/service/postgres/converters/PostgresFunctionConverterConfig.java
Outdated
Show resolved
Hide resolved
Need this one too - hypertrace/hypertrace-ingester#340 to fix integration test. |
No description provided.