Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for distinct count function for array column in postgres #174

Merged
merged 8 commits into from
Sep 6, 2022

Conversation

saxenakshitiz
Copy link
Contributor

No description provided.

@saxenakshitiz saxenakshitiz requested a review from a team August 29, 2022 14:44
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #174 (43355a2) into main (b92ad9b) will increase coverage by 1.39%.
The diff coverage is 95.47%.

@@             Coverage Diff              @@
##               main     #174      +/-   ##
============================================
+ Coverage     77.13%   78.52%   +1.39%     
- Complexity      784      853      +69     
============================================
  Files            79       80       +1     
  Lines          3420     3595     +175     
  Branches        392      405      +13     
============================================
+ Hits           2638     2823     +185     
+ Misses          608      597      -11     
- Partials        174      175       +1     
Flag Coverage Δ
integration 78.52% <95.47%> (+1.39%) ⬆️
unit 71.58% <93.82%> (+2.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/converters/PostgresFunctionConverterConfig.java 48.27% <40.00%> (+2.44%) ⬆️
...postgres/converters/PostgresFunctionConverter.java 76.87% <92.10%> (+12.35%) ⬆️
...gres/converters/DefaultColumnRequestConverter.java 81.54% <96.77%> (+0.77%) ⬆️
...e/postgres/QueryRequestToPostgresSQLConverter.java 96.29% <97.45%> (+1.42%) ⬆️
.../postgres/converters/PostgresExecutionContext.java 98.03% <98.03%> (ø)
...e/core/query/service/postgres/TableDefinition.java 82.66% <0.00%> (+5.33%) ⬆️
...y/service/multivalue/MultiValueTransformation.java 100.00% <0.00%> (+7.69%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kotharironak
Copy link
Contributor

For the integration test, it seems some client libs to pinot or something has changed that might be causing it to fail. We may have to pull the latest images to local and need to try.

 2022-08-29 14:49:53.491 [Test worker] ERROR 🐳 [hypertrace/hypertrace-view-generator:main] - Could not start container
    org.testcontainers.containers.ContainerLaunchException: Timed out waiting for log output matching '.* Started admin service on port: 8099.*'
    	at org.testcontainers.containers.wait.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:49) ~[testcontainers-1.16.2.jar:?]
    	at org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:51) ~[testcontainers-1.16.2.jar:?]
    	at org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:929) ~[testcontainers-1.16.2.jar:?]

this.resolvedOrderByDescBool = new ArrayList<>();
}

public ExecutionContext getExecutionContext() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is lombok part of the buid? if, yes, can we replace it with pre-processor annotation?

@kotharironak
Copy link
Contributor

Need this one too - hypertrace/hypertrace-ingester#340 to fix integration test.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@saxenakshitiz saxenakshitiz merged commit 4c5a954 into main Sep 6, 2022
@saxenakshitiz saxenakshitiz deleted the distinct_count_array_column branch September 6, 2022 04:51
@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Unit Test Results

  38 files  ±0    38 suites  ±0   9s ⏱️ +2s
257 tests +4  257 ✔️ +4  0 💤 ±0  0 ❌ ±0 

Results for commit 4c5a954. ± Comparison against base commit b92ad9b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants