feat: add scalar functions in postgres #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #165 +/- ##
============================================
+ Coverage 78.02% 78.11% +0.08%
Complexity 758 758
============================================
Files 79 79
Lines 3318 3317 -1
Branches 371 371
============================================
+ Hits 2589 2591 +2
+ Misses 568 565 -3
Partials 161 161
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| CREATE OR REPLACE FUNCTION dateTimeConvert (bigint, bigint) RETURNS bigint AS $$ select ((($1 + $2 - 1)/$2)*$2) $$ LANGUAGE SQL; | ||
|
|
||
| CREATE OR REPLACE FUNCTION conditional (condition text, first text, second text) |
There was a problem hiding this comment.
should condition be text or boolean? similarly, is there any kind of "any" type for first and second?
There was a problem hiding this comment.
That is what we discussed yesterday right that condition can be null as well. That is reason I have used text, and converting to boolean only if it is not null.
All arguments must be of specific type in postgres functions.
aaron-steinfeld
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
HTPinotQueriesTest > testServicesQueriesForAvgRateWithTimeAggregation() FAILED
org.opentest4j.AssertionFailedError: expected: <4> but was: <5>
at app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
at app//org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)
at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:150)
at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:145)
at app//org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:527)
at app//org.hypertrace.core.query.service.htqueries.HTPinotQueriesTest.testServicesQueriesForAvgRateWithTimeAggregation(HTPinotQueriesTest.java:396)
None of the changes in PR impact pinot implementation in any way. Let me check this failure by running locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.