chore: Split postgres url in to parts. #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #157 +/- ##
============================================
+ Coverage 77.28% 77.84% +0.56%
Complexity 758 758
============================================
Files 80 79 -1
Lines 3310 3300 -10
Branches 368 368
============================================
+ Hits 2558 2569 +11
+ Misses 590 569 -21
Partials 162 162
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
query-service/src/integrationTest/resources/configs/query-service/postgres/application.conf
Outdated
Show resolved
Hide resolved
query-service-impl/src/main/java/org/hypertrace/core/query/service/QueryServiceConfig.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
||
| private RequestHandlerClientConfig(Config config) { | ||
| this.type = config.getString(CONFIG_PATH_TYPE); | ||
| this.connectionString = config.getString(CONFIG_PATH_CONNECTION_STRING); | ||
| if (config.hasPath(CONFIG_PATH_USER)) { | ||
| this.user = Optional.of(config.getString(CONFIG_PATH_USER)); |
There was a problem hiding this comment.
nit:
this.user = config.hasPath(CONFIG_PATH_USER) ? Optional.of(config.getString(CONFIG_PATH_USER)) : Optional.empty()
There was a problem hiding this comment.
Will do it in follow up PR
...ce-impl/src/main/java/org/hypertrace/core/query/service/postgres/PostgresResultAnalyzer.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.