Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: wrap with grpc factory, add health check #148

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

aaron-steinfeld
Copy link
Contributor

Description

Refactor to use common factory framework. Also updated helm deployment to use out of the box health service provided by framework.

Testing

Ran integration tests, deployed to local cluster to verify health check

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@aaron-steinfeld aaron-steinfeld requested a review from a team July 1, 2022 04:38
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #148 (97702ea) into main (19cf407) will increase coverage by 0.42%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #148      +/-   ##
============================================
+ Coverage     82.19%   82.62%   +0.42%     
- Complexity       14      630     +616     
============================================
  Files            66       65       -1     
  Lines          2393     2354      -39     
  Branches        244      243       -1     
============================================
- Hits           1967     1945      -22     
+ Misses          329      312      -17     
  Partials         97       97              
Flag Coverage Δ
integration 82.62% <100.00%> (+0.42%) ⬆️
unit 80.13% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ce/core/query/service/AttributeClientProvider.java 100.00% <100.00%> (ø)
...ertrace/core/query/service/QueryServiceModule.java 100.00% <100.00%> (ø)
...rtrace/core/query/service/QueryServiceStarter.java 100.00% <100.00%> (+44.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19cf407...97702ea. Read the comment docs.

@github-actions

This comment has been minimized.

@aaron-steinfeld aaron-steinfeld merged commit 60ab34b into main Jul 5, 2022
@aaron-steinfeld aaron-steinfeld deleted the factory-service branch July 5, 2022 16:58
@github-actions
Copy link

github-actions bot commented Jul 5, 2022

Unit Test Results

  36 files  ±0    36 suites  ±0   9s ⏱️ ±0s
203 tests ±0  203 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 60ab34b. ± Comparison against base commit 19cf407.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants