-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure block listener retry configuration #158
Conversation
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
@EnriqueL8 Migration logic added, ready for another look |
Signed-off-by: Chengxuan Xing <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After looking the PR - I think bigger changes are needed here. So we use these delay and retry configurations across three things:
- Block Listener
- Event Listener
- Event Stream
If we are deciding to split one, we should split them all to be configurable. Right not this PR proposes only splitting block listeners but those configurations still apply to the other two which is odd
@EnriqueL8 thanks for the question. Even though the I'll pick a better name for the configuration to make that clear. |
Signed-off-by: Chengxuan Xing <[email protected]>
@EnriqueL8 ready for another look again |
Signed-off-by: Chengxuan Xing <[email protected]>
…refactor-retry-config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense now! Thanks for the clarification @Chengxuan
Move the block listener retry configuration outside the
retry
attribute as that was for resty client retry. Having them together is confusing.