-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise generate script and upgrade abigen #3
Revise generate script and upgrade abigen #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comment above regarding the import statement in generate.sh
. I think there is an error in the package name and it would be good if we could test the script in the CI.
I see that you didn't upgrade to the latest version of abigen. What's the reason for that?
Signed-off-by: Philipp-Florens Lehwalder <[email protected]>
Signed-off-by: Philipp-Florens Lehwalder <[email protected]>
Signed-off-by: Philipp-Florens Lehwalder <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You didn't want to run generate.sh
in the CI to test that it is valid, as I suggested in my previous comment?
Also, we talked about changing the folder structure and removing --allow-paths
. Is there a particular reason you didn't apply that? I think it is confusing and unnecessary that the solidity contracts, which are only used to generate the binding, are located at the root directory of the repository, and not with the generate script in the bindings
folder. (which by the way could be renamed to binding
)
I noticed that locally after running the generate script git shows me a bunch of untracked files. Please create a
|
Signed-off-by: Philipp-Florens Lehwalder <[email protected]>
aab6b1f
to
c97d639
Compare
True, I forgot about this, I now changed that. @matthiasgeihs |
bc4348e
to
0891c22
Compare
Signed-off-by: Philipp-Florens Lehwalder <[email protected]>
Signed-off-by: Philipp-Florens Lehwalder <[email protected]>
Signed-off-by: Philipp-Florens Lehwalder <[email protected]>
c2c667c
to
47b5124
Compare
9d3adde
to
59e46c4
Compare
Signed-off-by: Philipp-Florens Lehwalder <[email protected]>
Signed-off-by: Philipp-Florens Lehwalder <[email protected]>
Signed-off-by: Matthias Geihs <[email protected]>
Signed-off-by: Matthias Geihs <[email protected]>
304e33d
to
fc41898
Compare
Signed-off-by: Philipp-Florens Lehwalder <[email protected]>
The access rights issue with the files coming out of Docker is related to: actions/runner#1317 (comment) . |
Signed-off-by: Matthias Geihs <[email protected]>
b88dc00
to
85882c8
Compare
de1eb54
to
711ca64
Compare
Signed-off-by: Matthias Geihs <[email protected]>
711ca64
to
5eae67f
Compare
This PR updates the
generate.sh
script to use the latest abigen version (v1.10.15) and includes the changes regarding the different bindings creations.