feat: Unit test for SD-JWT Flow (Issuer, Holder, Verifier) #3462
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3462 +/- ##
=======================================
Coverage 87.64% 87.64%
=======================================
Files 350 350
Lines 47436 47450 +14
=======================================
+ Hits 41573 41586 +13
- Misses 4350 4351 +1
Partials 1513 1513
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Unit test for SD-JWT Flow Closes hyperledger-archives#3461 Signed-off-by: Sandra Vrtikapa <[email protected]>
There was a problem hiding this comment.
From Section 5.5.1 of spec
If no Holder Binding JWT is included, the Combined Format for Presentation ends with the ~ character after the last Disclosure.
It means in case of holder disclosure, there will be a stray ~ at the end of disclosures list.
| sdJWTSerialized, e := token.Serialize(false) | ||
| r.NoError(e) | ||
|
|
||
| fmt.Println(fmt.Sprintf("issuer SD-JWT: %s", sdJWTSerialized)) |
There was a problem hiding this comment.
is this fmt.println() leftover?
There was a problem hiding this comment.
No, I left print outs on purpose to show output formats.
|
Yes, according to spec if there is no holder binding it should end with ~. I will fix this today since we currently don't have holder binding. I will work on holder binding next week. |
Unit test for SD-JWT Flow.
Closes #3461
Signed-off-by: Sandra Vrtikapa [email protected]