This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
feat: Present proof - signs the presentation #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2596 +/- ##
==========================================
- Coverage 88.67% 88.66% -0.01%
==========================================
Files 263 263
Lines 20188 20249 +61
==========================================
+ Hits 17901 17954 +53
- Misses 1332 1336 +4
- Partials 955 959 +4
Continue to review full report at Codecov.
|
Signed-off-by: Andrii Soluk <[email protected]>
soluchok
requested review from
fqutishat,
troyronda,
rolsonquadras,
llorllale and
baha-ai
| return err | ||
| } | ||
|
|
||
| methodID := fingerprint.KeyFingerprint(bls12381g2pub, pubKey) |
There was a problem hiding this comment.
@Baha-sk is going to add Create DID Key feature for bls12381 keys, please add a follow up task for him to replace this code with create bbs DID key api.
sudeshrshetty
approved these changes
Mar 3, 2021
llorllale
reviewed
Mar 3, 2021
| SignatureRepresentation: verifiable.SignatureProofValue, | ||
| Suite: bbsblssignature2020.New( | ||
| suite.WithSigner(newBBSSigner(km, cr, kid)), | ||
| suite.WithVerifier(bbsblssignature2020.NewG2PublicKeyVerifier()), |
There was a problem hiding this comment.
nit - you don't need a verifier when signing
There was a problem hiding this comment.
I don't think so. I will try to remove it.
llorllale
approved these changes
Mar 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, we will sign the presentation with
BbsBlsSignature2020(if a signature is needed). Also, it can be changed by providing an option e.gWithAddProofFn.Signed-off-by: Andrii Soluk [email protected]