Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to cargo-check-external-types 0.1.13 #2021

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

tottoto
Copy link
Collaborator

@tottoto tottoto commented Oct 25, 2024

This seems to be introduced at the recent changes in pin-project.

taiki-e/pin-project#357

@jenr24-architect
Copy link
Contributor

Bumping for #2008

@taiki-e
Copy link
Contributor

taiki-e commented Oct 29, 2024

fwiw, this is a cargo-check-external-types bug: taiki-e/pin-project-lite#86

@tottoto tottoto force-pushed the add-pin-project-to-external-type branch 2 times, most recently from 83141ea to 965cdd0 Compare October 29, 2024 14:52
@tottoto
Copy link
Collaborator Author

tottoto commented Oct 29, 2024

Thanks. Added a comment that these are workaround.

@tottoto tottoto requested a review from LucioFranco October 31, 2024 12:50
@taiki-e
Copy link
Contributor

taiki-e commented Oct 31, 2024

This issue has been fixed in cargo-check-external-types 0.1.13.

@tottoto tottoto force-pushed the add-pin-project-to-external-type branch from 965cdd0 to 264efb7 Compare October 31, 2024 15:39
@tottoto tottoto changed the title chore: Add pin-project crate to external type chore: Update to cargo-check-external-types 0.1.13 Oct 31, 2024
@tottoto
Copy link
Collaborator Author

tottoto commented Oct 31, 2024

Changed to update to cargo-check-external-types 0.1.13.

https://github.com/awslabs/cargo-check-external-types/releases/tag/v0.1.13

@jenr24-architect
Copy link
Contributor

@LucioFranco bumping this again for #2008!

@tottoto tottoto added this pull request to the merge queue Nov 5, 2024
Merged via the queue into hyperium:master with commit 4f8beb6 Nov 5, 2024
17 checks passed
@tottoto tottoto deleted the add-pin-project-to-external-type branch November 5, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants