-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cargo): set openssl to compatible v0.4.3 #348
Conversation
In openssl >= 0.5.0, it's using `std::io`, which doesn't work with std::old_io used in hyper. To make it work consistently, `Cookie` was reset to the previous version v0.1.13 as well, which depends on our compatible openssl version.
Oh, and it would be great if you could make a release right away, as I am still suffering from this bug. |
@Byron Thanks for the PR, but I don't think we'll be taking this approach right now, but will instead merge a fix to migrate to You can always depend on a git fork of hyper with those dependencies changed if you need something running right this second. |
That's what I am doing, and thanks to buggy cargo it recompiles hyper whenever I run Would it hurt to have a working version in the meanwhile ? Travis likes it too, so will everyone just pulling hyper from crates.io today. A working version is a merge and a publish away, which helps everyone today. Tomorrow is another day, which should upgrade to std::io to track latest. |
Ok, you've convinced me. I'll reopen and let @seanmonstar weigh in. |
Thank you :) ! My change shouldn't even conflict with anything you cooked up in the meanwhile. If you merge, you'd just have to remember to undo my changes to track the latest openssl. Seems doable, let's see what @seanmonstar thinks about that. |
You can quite easily edit the Cargo.toml to set the openssl/cookie On Sat, Feb 28, 2015, 4:44 AM Sebastian Thiel [email protected]
|
Thanks for that idea, this actually works ! It's important to put these in the right order though: openssl = "= 0.4.3"
cookie = "= 0.1.13"
# If hyper would be listed before openssl, there would be a version conflict. Makes sense.
hyper = "*" Compiling feels so much better now. Besides, I learned something new about cargo today, which shall help me to remain independent and workaround all of the current issues. |
Sorry, I meant Cargo.lock On Sat, Feb 28, 2015, 12:24 PM Sebastian Thiel [email protected]
|
That I tried in the very beginning - cargo would keep overwriting the file, it seems it's not really supposed to be edited. |
You can edit the lock file, as I said that's what Servo does. You however On Sat, Feb 28, 2015, 12:39 PM Sebastian Thiel [email protected]
|
In openssl >= 0.5.0, it's using
std::io
, which doesn't work withstd::old_io used in hyper.
To make it work consistently,
Cookie
was reset to the previousversion v0.1.13 as well, which depends on our compatible openssl
version.