Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding jenkins pipeline #1

Merged
merged 5 commits into from
Sep 25, 2022
Merged

Conversation

ghost
Copy link

@ghost ghost commented Sep 21, 2022

This PR is needed for RES-32
It includes work for:

  • Separating Dockerfiles for React and Flask
  • Create docker compose file to easily run the application in docker
  • Adding jenkins pipeline

Related PR: https://github.com/huspy/huspy-services/pull/12

Copy link

@javierdearcos javierdearcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert in the matter, but everything seems good to me and I love having the services separate and coordinate with Docker compose.

Just two things that may have no sense but intrigue me:

  • We are using 0.0.0.0 as an IP in one service. Could this be in some situations a little dangerous?
  • I think we are using slack to send some notifications. Can we use Datadog for this? maybe not now but in the future

@huspy-souzaxx
Copy link

We still don't have the ECR for this project and the way that the Jenkinsfile is right now it won't work in the new cluster with argocd.

@nikitasu
Copy link

@huspy-souzaxx would it be possible to move forward with this today/tomorrow? As we agreed no special CPU setup needed, just to make sure this thing works :)

Copy link

@dflima dflima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@huspy-souzaxx huspy-souzaxx force-pushed the feat/res-32_adding_jenkins_pipe branch from 12ff8ff to ae625cf Compare September 25, 2022 10:13
@huspy-souzaxx huspy-souzaxx merged commit c3663d5 into main Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants