Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update text sizes in inputs for improved Safari support #1550

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

ieedan
Copy link
Contributor

@ieedan ieedan commented Dec 12, 2024

Fixes #1548

  • Updates <Textarea/>, <Input/>, and <Command.Input/> to use the same styles used in the shadcn/ui commit
  • Bumps bits-ui -> next.71

P.S. <Command.Input/> isn't in that original commit but I think it should be added anyways since it will cause the same issue

Copy link

changeset-bot bot commented Dec 12, 2024

⚠️ No Changeset found

Latest commit: 62fddf6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 12, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview 62fddf6

@waedi
Copy link

waedi commented Dec 12, 2024

Thanks for the fast fix!
I saw you used sm:text-sm instead of md:text-sm in all but one file. I guess that is a typo?

@ieedan
Copy link
Contributor Author

ieedan commented Dec 12, 2024

Thanks for the fast fix! I saw you used sm:text-sm instead of md:text-sm in all but one file. I guess that is a typo?

You're right thank you for catching this!

@ieedan
Copy link
Contributor Author

ieedan commented Dec 12, 2024

All good now!

Copy link
Owner

@huntabyte huntabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks man!

@huntabyte huntabyte merged commit 426f549 into huntabyte:next Dec 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants