Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper initialization of the bridge pot account balances in genesis #698

Merged
merged 8 commits into from
Jul 20, 2023

Conversation

dmitrylavrenov
Copy link
Contributor

@dmitrylavrenov dmitrylavrenov commented Jul 19, 2023

Copy link
Contributor

@MOZGIII MOZGIII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Left a few comments, and we probably need to add the verifier itself... Which could be added in a separate PR.
This looks good, so probably would be a good time to merge and continue work in the subsequent PRs...

Just one question though - we have two of these pallets, would we also have two validators? It makes sense, kind of, but I'm just asking...

@dmitrylavrenov
Copy link
Contributor Author

dmitrylavrenov commented Jul 20, 2023

This is great! Left a few comments, and we probably need to add the verifier itself... Which could be added in a separate PR. This looks good, so probably would be a good time to merge and continue work in the subsequent PRs...

Just one question though - we have two of these pallets, would we also have two validators? It makes sense, kind of, but I'm just asking...

I see, it's a great question as I was thinking about it as well. In such implementation we have 2 verifiers for each pallet. I was a little bit confused as it has some pros and cons. But during tests implementation I've come up that it can provide more independent features, imo.

@dmitrylavrenov dmitrylavrenov marked this pull request as ready for review July 20, 2023 09:15
@dmitrylavrenov dmitrylavrenov requested a review from MOZGIII July 20, 2023 09:16
@dmitrylavrenov dmitrylavrenov added this pull request to the merge queue Jul 20, 2023
Merged via the queue into master with commit 311a930 Jul 20, 2023
@dmitrylavrenov dmitrylavrenov deleted the bridge-genesis-check branch July 20, 2023 10:19
dmitrylavrenov added a commit that referenced this pull request Aug 16, 2023
github-merge-queue bot pushed a commit that referenced this pull request Aug 16, 2023
…enesis (#698)" (#728)

* Revert "Proper initialization of the bridge pot account balances in genesis (#698)"

This reverts commit 311a930.

* Fix features-snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants