Switch to workspace dependencies

[MOZGIII]

Closes #610

[MOZGIII]

As you can see, CI is red, and the builds are broken. This is without any changes to the Cargo.lock, so it must that the features are resolving differently somehow.
I'll investigate this later, but for now, @dmitrylavrenov if you can spot the root cause of this at a glance (i.e. without too much effort) please let me know.

[dmitrylavrenov]

As you can see, CI is red, and the builds are broken. This is without any changes to the Cargo.lock, so it must that the features are resolving differently somehow.
I'll investigate this later, but for now, @dmitrylavrenov if you can spot the root cause of this at a glance (i.e. without too much effort) please let me know.

As I figured out workspace maintains the additive nature of the package dependency, it can enable default features but it can't disable them:

• Workspace dependency features don't resolve correctly with target-dependent features rust-lang/cargo#11779 (comment)
• fix(toml): Add default-features to TomlWorkspaceDependency rust-lang/cargo#11409 (comment)

Already pushed the commit with additive nature.

[MOZGIII]

I see what the problem is. I don't like the idea of having default features disabled for some of the workspace deps, but enabled for the rest. How about we disbale default features for all workspace deps, and the selectively enable them as needed?

[dmitrylavrenov]

I see what the problem is. I don't like the idea of having default features disabled for some of the workspace deps, but enabled for the rest. How about we disbale default features for all workspace deps, and the selectively enable them as needed?

Agree with you, it should avoid having confusion in mind.

[MOZGIII]

@dmitrylavrenov thx for the help, I'll take care of the rest.

[dmitrylavrenov]

@MOZGIII default features have beet set to false for all deps.
Please, check.

[MOZGIII]

I think we must also run local tests for this to be sure (to see if we maybe disabled some features unexpectedly that don't break the compilation, but reduce the effective feature set for instance). Should be alright though.

[MOZGIII]

Status update: this can be merged, but we decided to introduce snapshotting of the active feature per dependency, land that at CI so we get an alert when features change, and then ensure this PR doesn't cause a snapshot change to rnsure we only purely rewrite the way we declare the features, and bit the actual sets of features.
@dmitrylavrenov please send an update on the progress of the specifics here once you have a chance

[MOZGIII]

See #687

The diff for the current branch is 7bbb1bd - I think it is acceptable.
It is also interesting to check the diff for my initial attempt - aa0c61a
And the diff between my first attempt and your additions - cac350a

[MOZGIII]

#687 is getting merged now, we can continue here

[dmitrylavrenov]

@MOZGIII Just merged master and resolved conflict. I guess it can be reviewed now.

[MOZGIII]

Can we make it so the features snapshot is unchanged?

[MOZGIII]

I suggest that we squash the commits in this PR and rebase on top of master so it's easier to achieve the changeset we are looking for here - which is to switch to the workspace dependencies without changes to the features snapshot. This is going to be non-trivial, especially with the current state of this PR, however, it is doable.

[dmitrylavrenov]

I suggest that we squash the commits in this PR and rebase on top of master so it's easier to achieve the changeset we are looking for here - which is to switch to the workspace dependencies without changes to the features snapshot. This is going to be non-trivial, especially with the current state of this PR, however, it is doable.

Spent time to properly rebase. Current features snapshot changes are related to default-features = false usage based on

How about we disbale default features for all workspace deps, and the selectively enable them as needed?

[dmitrylavrenov]

@MOZGIII Check again, please. Features snapshot hasn't been changed.

[MOZGIII]

Looks great! I'll take some time to review to make sure I understand the tradeoffs taken here.

[MOZGIII]

It would be nice to add a clippy lint to only allow workspace dependencies. This doesn't look too difficult, check out this for a reference: https://github.com/rust-lang/rust-clippy/tree/master/clippy_lints/src/cargo