remove the obsolete code related to fairscale FSDP #26651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
statelesshz
commented
Oct 7, 2023
|
@muellerzr and @ArthurZucker could you please take a look at this PR? Thanks :D |
muellerzr
approved these changes
Oct 23, 2023
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
statelesshz
commented
Oct 24, 2023
| " `--half_precision_backend apex`: GPU bf16 is not supported by apex. Use" | ||
| " `--half_precision_backend cuda_amp` instead" | ||
| ) | ||
| raise ValueError(" `--half_precision_backend apex`: GPU bf16 is not supported by apex.") |
There was a problem hiding this comment.
update error info. cc @ArthurZucker
|
@amyeroberts sorry for bothering, could you please review this PR? |
amyeroberts
approved these changes
Oct 30, 2023
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
* remove the obsolete code related to fairscale FSDP * apple review suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As the title says, this PR introduces two modifications:
--bf16and--half_precision_backend apexas thecuda_ampoption is no longer available. I'm not sure how to write it more appropriately, so I just useautoinstead.