Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ControlNet SDXL training] fixes in the training script #4223

Merged
merged 11 commits into from
Jul 25, 2023
Merged

[ControlNet SDXL training] fixes in the training script #4223

merged 11 commits into from
Jul 25, 2023

Conversation

sayakpaul
Copy link
Member

@sayakpaul sayakpaul commented Jul 24, 2023 •
edited
Loading

Fixes #4206. Additionally

  • adds a test for SDXL ControlNet training.
  • adds licensing to the model card so that repos can have public visibility be default

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 24, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@sayakpaul sayakpaul changed the title [ControlNet SDXL training] specify the pipeline call arguments to avoid ambiguity [ControlNet SDXL training] fixes in the training script Jul 24, 2023
@sayakpaul sayakpaul marked this pull request as draft July 24, 2023 05:02
@sayakpaul sayakpaul marked this pull request as ready for review July 24, 2023 14:38
patrickvonplaten
patrickvonplaten approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sayakpaul sayakpaul merged commit fed1237 into main Jul 25, 2023
@sayakpaul sayakpaul deleted the controlnet-training-fix branch July 25, 2023 00:01
@sayakpaul sayakpaul mentioned this pull request Jul 25, 2023
Closed
orpatashnik pushed a commit to orpatashnik/diffusers that referenced this pull request Aug 1, 2023
@sayakpaul @orpatashnik
[ControlNet SDXL training] fixes in the training script (huggingface#…
c680249 
…4223)

* fix: huggingface#4206

* add: sdxl controlnet training smoketest.

* remove unnecessary token inits.

* add: licensing to model card.

* include SDXL licensing in the model card and make public visibility default

* debugging

* debugging

* disable local file download.

* fix: training test.

* fix: ckpt prefix.
orpatashnik pushed a commit to orpatashnik/diffusers that referenced this pull request Aug 1, 2023
@sayakpaul @orpatashnik
[ControlNet SDXL training] fixes in the training script (huggingface#…
6e4e77e 
…4223)

* fix: huggingface#4206

* add: sdxl controlnet training smoketest.

* remove unnecessary token inits.

* add: licensing to model card.

* include SDXL licensing in the model card and make public visibility default

* debugging

* debugging

* disable local file download.

* fix: training test.

* fix: ckpt prefix.
orpatashnik pushed a commit to orpatashnik/diffusers that referenced this pull request Aug 1, 2023
@sayakpaul @orpatashnik
[ControlNet SDXL training] fixes in the training script (huggingface#…
b093fca 
…4223)

* fix: huggingface#4206

* add: sdxl controlnet training smoketest.

* remove unnecessary token inits.

* add: licensing to model card.

* include SDXL licensing in the model card and make public visibility default

* debugging

* debugging

* disable local file download.

* fix: training test.

* fix: ckpt prefix.
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@sayakpaul
[ControlNet SDXL training] fixes in the training script (huggingface#…
9a045c1 
…4223)

* fix: huggingface#4206

* add: sdxl controlnet training smoketest.

* remove unnecessary token inits.

* add: licensing to model card.

* include SDXL licensing in the model card and make public visibility default

* debugging

* debugging

* disable local file download.

* fix: training test.

* fix: ckpt prefix.
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
@sayakpaul
[ControlNet SDXL training] fixes in the training script (huggingface#…
2fcf395 
…4223)

* fix: huggingface#4206

* add: sdxl controlnet training smoketest.

* remove unnecessary token inits.

* add: licensing to model card.

* include SDXL licensing in the model card and make public visibility default

* debugging

* debugging

* disable local file download.

* fix: training test.

* fix: ckpt prefix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickvonplaten patrickvonplaten patrickvonplaten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the main branch is broken for controlnet training with sdxl
3 participants
@sayakpaul @HuggingFaceDocBuilderDev @patrickvonplaten