Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Other modalities #4205

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Conversation

stevhliu
Copy link
Member

This PR updates the other modality section in the docs, most of which are "coming soon" and don't add much content/value right now. We can add them back when we have more substantive content for these topics.

For the molecular conformation example, what do you think about turning it into a blog post? If we include it in the docs (instead of just a link to a notebook), do you think it’ll be too advanced + is there interest in it?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 21, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stevhliu stevhliu merged commit 5470a4f into huggingface:main Jul 24, 2023
orpatashnik pushed a commit to orpatashnik/diffusers that referenced this pull request Aug 1, 2023
remove coming soon, rl pipeline
orpatashnik pushed a commit to orpatashnik/diffusers that referenced this pull request Aug 1, 2023
remove coming soon, rl pipeline
orpatashnik pushed a commit to orpatashnik/diffusers that referenced this pull request Aug 1, 2023
remove coming soon, rl pipeline
@stevhliu stevhliu deleted the other-modalities branch August 10, 2023 18:04
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
remove coming soon, rl pipeline
@hilookas
Copy link
Contributor

It seems like the page is still on the huggingface documents, https://huggingface.co/docs/diffusers/main/en/using-diffusers/rl

Maybe we can clean the page cache or redirect this page to https://huggingface.co/docs/diffusers/main/en/api/pipelines/value_guided_sampling ?

hilookas added a commit to hilookas/diffuser that referenced this pull request Dec 28, 2023
According to huggingface/diffusers#4205 the original page link was updated.
@stevhliu
Copy link
Member Author

stevhliu commented Jan 3, 2024

Thanks for reporting, we'll look into this!

@mishig25, the rl.md page should only be accessible on v18.0 of the docs and I'm not sure why it can be viewed on the main version (it doesn't show up in the main version's table of contents). I think if you're viewing this page on v18.0 and try to view it on a newer version of the docs, it redirects to the main version where it shouldn't exist. Do you think it'd be possible to add something that says this doc has been removed or that it can be found here instead now?

AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
remove coming soon, rl pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants