Add support for model version in Vertex AI #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurGoupil
approved these changes
Sep 27, 2024
nsarrazin
approved these changes
Sep 27, 2024
|
@nsarrazin I'm not sure I can merge the PR. Could you do it when you believe it's good to go ? |
ice91
pushed a commit
to ice91/chat-ui
that referenced
this pull request
Oct 30, 2024
* Add support for model version in Vertex AI * Update src/lib/server/endpoints/google/endpointVertex.ts Co-authored-by: goupilew <[email protected]> * fix: optional chaining on extraBody --------- Co-authored-by: goupilew <[email protected]> Co-authored-by: Nathan Sarrazin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping the version of Gemini from gemini-1.5-pro-001 to gemini-1.5-pro-002 should be completly transparent for the user.
Right now, this is not the case as the Gemini model version is strongly coupled with the HuggingChat model.
This PR add supports for
extraBody.model_versionin endpointVertexParametersSchema