Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi guys, been playing with the API and took the liberty of sloppily adding some functionality and fixing some bug. #13

Merged
merged 6 commits into from
Apr 8, 2022

Conversation

JamMassey
Copy link
Contributor

@JamMassey JamMassey commented Mar 31, 2022

So essentially there was a bug in the category and subcategory parameters that could be passed to the courses function - '&' was not supported in the value passed and would not return any data. This is now fixed.

Also, I added the functionality to control the level of return data through a fields parameter, pretty much as is described at https://www.udemy.com/developers/affiliate/ under "Use of Fields and Field Lists"

Nice work guys, saved me a lot of time.

If you can see any way to clearly clean up my logic a little I'd appreciate it!

hudsonbrendon and others added 6 commits September 23, 2021 23:52
Previously the subcategory and category parameters would error out when referencing any subcategory with a '&'  in the title, this patches that and also add support for Udemy's fields parameter - " Udemy Affiliate API supports an optional request parameter fields to customize which fields should be returned for a particular object type."
@JamMassey JamMassey changed the base branch from master to develop March 31, 2022 02:51
@hudsonbrendon hudsonbrendon merged commit 691202c into hudsonbrendon:develop Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants