postcss-sorting complains about less-mixins

[stephanschubert]

When less-mixins is used:

    "order/order": [
      "custom-properties",
      "dollar-variables",
      "at-variables",
      "declarations",
      "rules",
      "at-rules",
      "less-mixins",
    ],
    "order/properties-alphabetical-order": true,

Result:

postcss-sorting: order: Every item in the array must be an object with a "type" property, or one of keywords: custom-properties, dollar-variables, at-variables, declarations, rules, at-rules.

Removing less-mixins "fixes" the error.

[hudochenkov]

Thank you for reporting!

Indeed, this problem exists, because postcss-sorting (a plugin which handles order fixing) doesn't support this keyword.

I believe it could be fixed if add to https://github.com/hudochenkov/postcss-sorting/blob/944da947a628192b54448368c197f586fbbe0c10/lib/getOrderData.js code similar to

stylelint-order/rules/order/getOrderData.js

Lines 19 to 20 in 3215ac3

	} else if (node.type === 'rule' && node.empty && !node.extend) {
	nodeType = 'less-mixins';

Consider contributing this fix, because Less is not in my priority.

While problem exists you can disable autofixing for order/order.

[NE-SmallTown]

Same problem.

@hudochenkov The bad I feel is that this will cause the entire file won't be fixed(it lets me think it's my own fault), I think we should just ignore less-mixins and still fix the file and throw the error rather than just log(for me, I even don't see the warning because it use console.log which use black font color and spend 2 hours to dig into the source code of stylelint-order)

What's your suggestion/plan to fix this? If @stephanschubert doesn't have time, I could send a PR for this.

[hudochenkov]

@NE-SmallTown Sorry, you faced this situation. It's a rare case when something was added to stylelint-order but wasn't reflected in postcss-sorting. My suggestion is to add support for less-mixins into postcss-sorting. I wrote above where to start.

[NE-SmallTown]

Never mind, I will take a look this weekend if @stephanschubert doesn't have time

[oller]

The ol' 18month later bump. I'm encountering this issue too, is it as easy a fix as the snippet in the thread above?

[hudochenkov]

Pretty much. Add new keyword and add tests for it.

[oller]

Good stuff, shall try and find some time tomorrow.

…

On Thu, 16 Apr 2020 at 19:59, Aleks Hudochenkov ***@***.***> wrote: Pretty much. Add new keyword and add tests for it. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#71 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJJZ5YPOEAYR5BMQLDXCPLRM5ISPANCNFSM4F6VECFQ> .

[Astrael1]

Fixing this requires adding some LESS parser to postcss-sorting e.g. postcss-less because postcss parser doesn't accept usage of LESS mixins and throws error

.le_mixin {
  color: red;
}

a {
  .le_mixin();
}

@hudochenkov do you allow adding that dependency or shall we just close this issue?

[hudochenkov]

I don't think it is needed. For 6 years this issue is open it only got 3 reactions.

But I'm open for a PR to postcss-sorting as described above.