Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pipes support in bodies. #532

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Fix pipes support in bodies. #532

merged 1 commit into from
Feb 15, 2019

Conversation

ixti
Copy link
Member

@ixti ixti commented Feb 14, 2019

Resolves #531

@ixti ixti force-pushed the fix-pipes-support branch from 40c9694 to ff8c33d Compare February 14, 2019 23:31
@ixti ixti force-pushed the fix-pipes-support branch from ff8c33d to 714da06 Compare February 15, 2019 00:13
janko
janko approved these changes Feb 15, 2019
View reviewed changes
Copy link
Member

@janko janko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@ixti
Copy link
Member Author

ixti commented Feb 15, 2019

@janko I was thinking about adding the same to form_data, but not sure how to do that - as it will fail on size anyway ;))

@janko
Copy link
Member

janko commented Feb 15, 2019

@ixti We only theoretically need to do it in HTTP::FormData::Readable#to_s, right? From what I can see, everything else should be working fine. If http.rb calls #rewind, it will fail with the same error. #size will be called only if Transfer-Encoding: chunked is not set (which is expected, as we need #size otherwise). Did I miss anything?

@ixti
Copy link
Member Author

ixti commented Feb 15, 2019

@janko I mean if one of parts of composable io will fail with this error - others will not be rewinded. But I guess it's an issue that should be discussed in form_data anyway, not here. :D

@ixti ixti merged commit 5765a48 into master Feb 15, 2019
@ixti ixti deleted the fix-pipes-support branch February 15, 2019 02:26
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jun 7, 2020
www/ruby-http: update to 4.4.1
0e84a93 
Update ruby-http to 4.4.1.


## 4.4.1 (2020-03-29)

* Backport [#590](httprb/http#590)
  Fix parser failing on some edge cases.
  ([@ixti])

## 4.4.0 (2020-03-25)

* Backport [#587](httprb/http#587)
  Fix redirections when server responds with multiple Location headers.
  ([@ixti])

* Backport [#599](httprb/http#599)
  Allow passing HTTP::FormData::{Multipart,UrlEncoded} object directly.
  ([@ixti])

## 4.3.0 (2020-01-09)

* Backport [#581](httprb/http#581)
  Add Ruby-2.7 compatibility.
  ([@ixti], [@janko])


## 4.2.0 (2019-10-22)

* Backport [#489](httprb/http#489)
  Fix HTTP parser.
  ([@ixti], [@fxposter])


## 4.1.1 (2019-03-12)

* Add `HTTP::Headers::ACCEPT_ENCODING` constant.
  ([@ixti])


## 4.1.0 (2019-03-11)

* [#533](httprb/http#533)
  Add URI normalizer feature that allows to swap default URI normalizer.
  ([@mamoonraja])


## 4.0.5 (2019-02-15)

* Backport [#532](httprb/http#532) from master.
  Fix pipes support in request bodies.
  ([@ixti])


## 4.0.4 (2019-02-12)

* Backport [#506](httprb/http#506) from master.
  Skip auto-deflate when there is no body.
  ([@Bonias])


## 4.0.3 (2019-01-18)

* Fix missing URL in response wrapped by auto inflate.
  ([@ixti])

* Provide `HTTP::Request#inspect` method for debugging purposes.
  ([@ixti])


## 4.0.2 (2019-01-15)

* [#506](httprb/http#506)
  Fix instrumentation feature.
  ([@paul])


## 4.0.1 (2019-01-14)

* [#515](httprb/http#515)
  Fix `#build_request` and `#request` to respect default options.
  ([@RickCSong])


## 4.0.0 (2018-10-15)

* [#482](httprb/http#482)
  [#499](httprb/http#499)
  Introduce new features injection API with 2 new feaures: instrumentation
  (compatible with ActiveSupport::Notification) and logging.
  ([@paul])

* [#473](httprb/http#473)
  Handle early responses.
  ([@janko-m])

* [#468](httprb/http#468)
  Rewind `HTTP::Request::Body#source` once `#each` is complete.
  ([@ixti])

* [#467](httprb/http#467)
  Drop Ruby 2.2 support.
  ([@ixti])

* [#436](httprb/http#436)
  Raise ConnectionError when writing to socket fails.
  ([@janko-m])

* [#438](httprb/http#438)
  Expose `HTTP::Request::Body#source`.
  ([@janko-m])

* [#446](httprb/http#446)
  Simplify setting a timeout.
  ([@mikegee])

* [#451](httprb/http#451)
  Reduce memory usage when reading response body.
  ([@janko-m])

* [#458](httprb/http#458)
  Extract HTTP::Client#build_request method.
  ([@tycoon])

* [#462](httprb/http#462)
  Fix HTTP::Request#headline to allow two leading slashes in path.
  ([@scarfacedeb])

* [#454](httprb/http#454)
  [#464](httprb/http#464)
  [#384](httprb/http#384)
  Fix #readpartial not respecting max length argument.
  ([@janko-m], [@marshall-lee])
@tarcieri tarcieri mentioned this pull request May 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janko janko janko approved these changes

@digitalextremist digitalextremist Awaiting requested review from digitalextremist

@sferik sferik Awaiting requested review from sferik

@tarcieri tarcieri Awaiting requested review from tarcieri

@zanker zanker Awaiting requested review from zanker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ixti @janko