-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x-forwarded-host overwrite for mutli level proxies #1267
Conversation
With more than 1 proxy the original host was lost, now it will be passed down the proxy chain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@jaggernoth host is probably most important but should we also default the other values so we are consistent? |
@jcrugzz : From what I can see in the code for other x-forwarded header entries new levels are concatenated as CSV values and I was considering making x-forwarded-host a CSV value as well but it would be much riskier as it may cause compatibility issues (CSV requires additional parsing). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @jcrugzz comment, but this PR is still 👍
As to the CSV value question @jaggernoth the research I briefly looked at did not suggest that as a format:
With more than 1 proxy the original host was lost, now it will be passed down the proxy chain
Let's consider a scenario
proxy (Internet-facing) -> proxy(load balancer) -> application
where both proxies will be based on node-http-proxy, with current logic original host to be lostWith updated logic the original forwarded host will be passed down the proxy chain