-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrobble works on 'Artist' and not on 'Album Artist'? #48
Comments
Yeah, I guess I could scrobble the album artist, if it is set. Sound reasonable? EDIT: Actually, the Last.fm has an optional field called albumArtist for scrobbles. I'll check if additionally setting that solves the problem. |
In my experience the situation is inverted, usually album artist is something like "Various" or "Various Artists". The artist tag is typically the artist for the track. Maybe some logic is needed to test album artist for "contains Various" before using it. |
This makes things a little more problematic as files are not usually tagged in a consistent manner :( I know that Last.fm does some auto-correction of input and probably has way smarter mechanisms. I'm unsure how to proceed here. |
Maybe a way to just include an option in the config file? We could have the best of both worlds. |
That's an idea. I'll do some testing first. Maybe it is sufficient to just submit both, artist and album artist, and let Last.fm choose the most appropriate. |
I am now also scrobbling the album artist. It's been pushed to the master branch, could you guys check if it works and see if it improves the artist detection? |
Whoops, must have disabled the issues feature accidentally. |
@hrkfdn Just got around to testing it, the artist scrobbled appears to be the same as before... :/ |
I think it would help to see how Clementine handles this issue. In the scrobbling section, Clementine has a feature called 'Scrobble using Album Artist tag when available' which works rather beautifully. |
I believe using album artist vs. artist depends on whether the album is a compilation (i.e. album artist is Various Artists or similar) or not. Beets for example has a flag for that. I'm not sure however if it is saved in the tags and available in mpd and mpd clients.
Am 30. Okt. 2017, 19:17 +0100 schrieb Vignesh Kumar <[email protected]>:
… I think it would help to see how Clementine handles this issue. In the scrobbling section, Clementine has a feature called 'Scrobble using Album Artist tag when available' which works rather beautifully.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
It looks like Clementine just sends the album artist instead of the artist,
if the option and tag are set. No further checking if it is "Various
artists" or something similar. I'll look into implementing that. Thanks for
testing! :)
…On Oct 30, 2017 19:43, "Daniel Schregenberger" ***@***.***> wrote:
I believe using album artist vs. artist depends on whether the album is a
compilation (i.e. album artist is Various Artists or similar) or not. Beets
for example has a flag for that. I'm not sure however if it is saved in the
tags and available in mpd and mpd clients.
Am 30. Okt. 2017, 19:17 +0100 schrieb Vignesh Kumar <
***@***.***>:
> I think it would help to see how Clementine handles this issue. In the
scrobbling section, Clementine has a feature called 'Scrobble using Album
Artist tag when available' which works rather beautifully.
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#48 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABNrMnDcU_vxM8ScbmX9T10cXdfAFEvks5sxhjlgaJpZM4QCCeo>
.
|
Squashed commit of the following: commit 76f4c69 Author: Henrik Friedrichsen <[email protected]> Date: Tue Oct 24 14:11:30 2017 +0200 fix typos commit 6a86c9a Author: Henrik Friedrichsen <[email protected]> Date: Tue Oct 24 14:02:32 2017 +0200 wip: scrobble albumArtist
You should always try submit as much info when scrobbling as possible, so if you have an album and a track artist you should send both based on the values set in the track metadata. You should leave them "as is" and not do anything additional with "artists" like "Various Artists". Last.fm should be able to work things out correctly on their end. I used to work there and co-wrote the backend of the scrobbling API so I at least know how things used to be :) So I think what you've done here with passing on whatever value was set for "Album Artist" if present in the metadata is correct. |
@massdosage That's good to know, thanks for chiming in. I'll leave it the way it is now, then, and close the issue. |
I've noticed that this plugin scrobbles each track with the artist and not the album artist, so the scrobbles don't end up adding up to total plays of artist.
for example -
Feather by Nujabes scrobbles to artist Nujabes feat. Cise Star & AKIN instead of just Nujabes, thus Nujabes ends up having no plays throughout an entire album as there are so many features...
I searched around for a one liner in the settings to solve this problem but it doesn't seem to a option.... kinda seems like a no brainer to scrobble using Album Artist.
The text was updated successfully, but these errors were encountered: