Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrobble works on 'Artist' and not on 'Album Artist'? #48

Closed
clasick opened this issue Oct 22, 2017 · 13 comments
Closed

Scrobble works on 'Artist' and not on 'Album Artist'? #48

clasick opened this issue Oct 22, 2017 · 13 comments

Comments

@clasick
Copy link

clasick commented Oct 22, 2017

I've noticed that this plugin scrobbles each track with the artist and not the album artist, so the scrobbles don't end up adding up to total plays of artist.

for example -
Feather by Nujabes scrobbles to artist Nujabes feat. Cise Star & AKIN instead of just Nujabes, thus Nujabes ends up having no plays throughout an entire album as there are so many features...

I searched around for a one liner in the settings to solve this problem but it doesn't seem to a option.... kinda seems like a no brainer to scrobble using Album Artist.

@hrkfdn
Copy link
Owner

hrkfdn commented Oct 24, 2017

Yeah, I guess I could scrobble the album artist, if it is set. Sound reasonable?

EDIT: Actually, the Last.fm has an optional field called albumArtist for scrobbles. I'll check if additionally setting that solves the problem.

@pcwalden
Copy link

In my experience the situation is inverted, usually album artist is something like "Various" or "Various Artists". The artist tag is typically the artist for the track. Maybe some logic is needed to test album artist for "contains Various" before using it.

@hrkfdn
Copy link
Owner

hrkfdn commented Oct 24, 2017

This makes things a little more problematic as files are not usually tagged in a consistent manner :( I know that Last.fm does some auto-correction of input and probably has way smarter mechanisms. I'm unsure how to proceed here.

@clasick
Copy link
Author

clasick commented Oct 24, 2017

Maybe a way to just include an option in the config file? We could have the best of both worlds.

@hrkfdn
Copy link
Owner

hrkfdn commented Oct 25, 2017

That's an idea. I'll do some testing first. Maybe it is sufficient to just submit both, artist and album artist, and let Last.fm choose the most appropriate.

@hrkfdn
Copy link
Owner

hrkfdn commented Oct 26, 2017

I am now also scrobbling the album artist. It's been pushed to the master branch, could you guys check if it works and see if it improves the artist detection?

@hrkfdn
Copy link
Owner

hrkfdn commented Oct 30, 2017

Whoops, must have disabled the issues feature accidentally.

@clasick
Copy link
Author

clasick commented Oct 30, 2017

@hrkfdn Just got around to testing it, the artist scrobbled appears to be the same as before... :/

@clasick
Copy link
Author

clasick commented Oct 30, 2017

I think it would help to see how Clementine handles this issue. In the scrobbling section, Clementine has a feature called 'Scrobble using Album Artist tag when available' which works rather beautifully.

@SuperBFG7
Copy link

SuperBFG7 commented Oct 30, 2017 via email

@hrkfdn
Copy link
Owner

hrkfdn commented Oct 30, 2017 via email

hrkfdn referenced this issue Nov 1, 2017
Squashed commit of the following:

commit 76f4c69
Author: Henrik Friedrichsen <[email protected]>
Date:   Tue Oct 24 14:11:30 2017 +0200

    fix typos

commit 6a86c9a
Author: Henrik Friedrichsen <[email protected]>
Date:   Tue Oct 24 14:02:32 2017 +0200

    wip: scrobble albumArtist
@massdosage
Copy link
Contributor

You should always try submit as much info when scrobbling as possible, so if you have an album and a track artist you should send both based on the values set in the track metadata. You should leave them "as is" and not do anything additional with "artists" like "Various Artists". Last.fm should be able to work things out correctly on their end. I used to work there and co-wrote the backend of the scrobbling API so I at least know how things used to be :) So I think what you've done here with passing on whatever value was set for "Album Artist" if present in the metadata is correct.

@hrkfdn
Copy link
Owner

hrkfdn commented Nov 6, 2017

@massdosage That's good to know, thanks for chiming in. I'll leave it the way it is now, then, and close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants