-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unhandled exception when reading file on Android #6
Comments
You are right about launch.. no idea why i missed that.. although there are still two |
Looks good to me. I'll close my PR then. |
This was addressed by #8 |
I had a crash report in Google Play Console caused by file_picker_writable trying to read a non-existent file (see amake/orgro#10).
The trace was
Unfortunately the coroutines ruin the trace, so I can't see how exactly execution got to
FilePickerWritableImpl#copyContentUriAndReturnFileInfo
. But there is some code path that doesn't properly catch exceptions.I think one problem might be that you use
launch
to start coroutines in several places, but have thetry
/catch
outside oflaunch
. Uncaught exceptions inlaunch
ed coroutines aren't forwarded to the parent scope and will crash the app on Android (link).The text was updated successfully, but these errors were encountered: