Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BPExamplesMorph Resizing #158

Merged
merged 11 commits into from
Oct 2, 2023
Merged

Fix BPExamplesMorph Resizing #158

merged 11 commits into from
Oct 2, 2023

Conversation

JoeAtHPI
Copy link
Collaborator

@JoeAtHPI JoeAtHPI commented Aug 9, 2023

Resolves child morphs of BPExample not using the full width of their parent, causing unwanted line breaks for wide browsers
image

becomes
image
when deleting intentional back spaces

@JoeAtHPI JoeAtHPI added bug Something isn't working visual Only visual changes have been made labels Aug 9, 2023
@JoeAtHPI JoeAtHPI requested a review from ekrebs5 August 9, 2023 15:33
@JoeAtHPI JoeAtHPI self-assigned this Aug 9, 2023
@ekrebs5
Copy link
Member

ekrebs5 commented Aug 17, 2023

One small problem: In some cases a lot of code seems to lead to the inner Morphs being layoutet too big, even tough with line breaks the code does not need that much space? Maybe we should add a max size if possible.

Picture attached, this also e.g. happens in BPTreeSceneMorph>>#resetForm

grafik

@JoeAtHPI
Copy link
Collaborator Author

@ekrebs5 the problem was the set width of the text field in editFieldFor: model text: getTextSelector onChange: setTextSelector onAccept: acceptTextSelector, which would always be the length of the text (also behaving like that in the old version). for the example morphs i set the property manually to #spacefill, along with the argument/'self'/'script' container. no overflow now + no need for max width
image
image

@JoeAtHPI JoeAtHPI force-pushed the error/fix-morph-resizing branch from bcfa3bb to 42b417b Compare August 22, 2023 15:58
Copy link
Member

@ekrebs5 ekrebs5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally had time to try this again. Looks good and can be merged :)

ekrebs5 and others added 3 commits October 2, 2023 09:57
…ad of name when determining whether two partial methods are the same. As a result the partial method is not correctly removed in case of a recompile within a new class.

(cherry-picked from commit b46aace)
@JoeAtHPI JoeAtHPI merged commit fa9ec69 into develop Oct 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working visual Only visual changes have been made
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants