Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused getHistoryMethodForAction function in Visit #1331

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

nanaya
Copy link
Contributor

@nanaya nanaya commented Oct 24, 2024

It's extracted to util file in #618 but the origin was left behind.

I'd like to run the test locally but playright doesn't play well with alpine so it's not tested 😬 The changes do look relatively straightforward though.

It's extracted to util file but the origin was left behind.
Copy link
Collaborator

@brunoprietog brunoprietog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nanaya!

@brunoprietog brunoprietog merged commit 6af611f into hotwired:main Dec 13, 2024
1 check passed
@nanaya nanaya deleted the unused-function branch December 13, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants