Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using TwirpError together with VError, more specifically the findCauseByName utility to find errors of specific kinds based on the
.name
property.As
twirp-ts
does not set a customname
property onTwirpError
, we have to rely on usinginstanceof TwirpError
, which works but is a bit unexpected.Wanted to open an issue, but figured I'd open this PR to propose + discuss. Feel free to close if this isn't something you want to add 👍