Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name property to TwirpError #73

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

frederikprijck
Copy link

We are using TwirpError together with VError, more specifically the findCauseByName utility to find errors of specific kinds based on the .name property.

As twirp-ts does not set a custom name property on TwirpError, we have to rely on using instanceof TwirpError, which works but is a bit unexpected.

Wanted to open an issue, but figured I'd open this PR to propose + discuss. Feel free to close if this isn't something you want to add 👍

@cristiandouce
Copy link

@fenos would you think this is something we could merge and release?

@cristiandouce
Copy link

@nningego sorry to ping you, would you know if anyone is maintaining this repo? 🙏

@armandogmendoza
Copy link
Collaborator

Hello @cristiandouce @frederikprijck
This package is in maintenance mode and we don't plan to do any new releases.
Our suggestion is that you fork the repo or find another fork that has been actively maintained.
Anyway, the patch looks good and it makes sense.

@MikeMcC399
Copy link

@armandogmendoza

This package is in maintenance mode and we don't plan to do any new releases.
Our suggestion is that you fork the repo or find another fork that has been actively maintained.

Please add this information to the README file and consider marking the npm package twirp-ts as deprecated in the npm registry.

I'm not sure if the statement means the repo is really in maintenance mode. If there are no more releases, not even for bug-fixes, then this would be an end-of-life status. Since there is no issue list available, it is not possible to report any issues. It might also be appropriate to archive the repo in this situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants