Keep the same ctx object for all hooks #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by coping the ctx object we prevent a hook from using it to track the request, this changes the code to keep the same object
e.g. I'm added a hook on
requestRoutedthat doesctx.somefield = somevalueand later inresponseSentI'm able to access that value. This currently works for all hooks exceptrequestRouted.I've also made a couple of CI changes, to run the make file in example, so that we check that the same code is kept up to date, and the same with the
__mock__that is used in tests as it was outdated.