Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client/server generation options #17

Merged
merged 1 commit into from
Jul 25, 2021

Conversation

jeffreylo
Copy link
Contributor

@jeffreylo jeffreylo commented Jul 23, 2021

Generation of the client/server code can now be controlled via plugin
options:

# Generate Twirp client and server code as standalone modules
--twirp_ts_opt=standalone

# Only generate Twirp client code
--twirp_ts_opt=client_only

# Only generate Twirp server code
--twirp_ts_opt=server_only

@jeffreylo jeffreylo force-pushed the jlo/server-generation branch 2 times, most recently from bbac7b8 to 80a28d9 Compare July 23, 2021 20:08
src/protoc-gen-twirp-ts/plugin.ts Outdated Show resolved Hide resolved
@jeffreylo jeffreylo force-pushed the jlo/server-generation branch from 1a0e53e to 8ba3128 Compare July 24, 2021 02:30
Generation of the client/server code can now be controlled via plugin
options:

```
\# Generate Twirp client and server code as standalone modules
--twirp_ts_opt=standalone

\# Only generate Twirp client code
--twirp_ts_opt=client_only

\# Only generate Twirp server code
--twirp_ts_opt=server_only
```
@jeffreylo jeffreylo force-pushed the jlo/server-generation branch from 8ba3128 to 926ba7d Compare July 24, 2021 19:30
@jeffreylo jeffreylo requested a review from fenos July 25, 2021 00:52
@jeffreylo jeffreylo marked this pull request as ready for review July 25, 2021 00:52
@fenos
Copy link
Contributor

fenos commented Jul 25, 2021

@jeffreylo this is fantastic!

@fenos fenos merged commit 64e591d into hopin-team:main Jul 25, 2021
@fenos
Copy link
Contributor

fenos commented Jul 25, 2021

This is now available to use on v2.3.0 Thanks @jeffreylo

@jeffreylo jeffreylo deleted the jlo/server-generation branch July 26, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants