Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incompatibility with aws 5.x provider #48

Closed
DavidS-ovm opened this issue Jun 9, 2023 · 1 comment · Fixed by #49
Closed

incompatibility with aws 5.x provider #48

DavidS-ovm opened this issue Jun 9, 2023 · 1 comment · Fixed by #49
Labels
type: bug Something isn't working

Comments

@DavidS-ovm
Copy link

terraform-aws-integrations/modules/kinesis-firehose-honeycomb/main.tf

Lines 18 to 25 in b846c4d

s3_configuration {
role_arn = aws_iam_role.firehose_s3_role.arn
bucket_arn = var.s3_failure_bucket_arn
buffer_size = var.s3_buffer_size
buffer_interval = var.s3_buffer_interval
compression_format = var.s3_compression_format
}

fails with the new 5.x aws provider from hashi:

resource/aws_kinesis_firehose_delivery_stream: Remove s3_configuration attribute from the root of the resource. s3_configuration is now a part of the following blocks: elasticsearch_configuration, opensearch_configuration, redshift_configuration, splunk_configuration, and http_endpoint_configuration (hashicorp/terraform-provider-aws#31138)
@jharley jharley added the type: bug Something isn't working label Jun 9, 2023
@ryan-keswick ryan-keswick mentioned this issue Jun 21, 2023
Merged
jharley pushed a commit that referenced this issue Jun 22, 2023
@ryan-keswick
Feat: Moving s3_configuration {} from root block to http_endpoint_con… (
b86c024 
#49)

## Which problem is this PR solving?

This is a breaking change and requires consumers to upgrade to 5.x.x AWS
terraform provider

- Closes #48

## Short description of the changes
hashicorp/terraform-provider-aws#31138


## How to verify that this has the expected result
Followed the changes specified
[here](hashicorp/terraform-provider-aws#31138)
and running in dev environment
@jharley
Copy link
Contributor

jharley commented Jun 23, 2023

Fix for this was just released in v1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@jharley @DavidS-ovm