-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Viam integration page #33925
base: next
Are you sure you want to change the base?
Add Viam integration page #33925
Conversation
📝 WalkthroughWalkthroughA new documentation file, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant HomeAssistant
participant Viam
User->>HomeAssistant: Initiate Viam integration
HomeAssistant->>Viam: Authenticate using API key or secrets
Viam-->>HomeAssistant: Authentication response
User->>HomeAssistant: Request data capture
HomeAssistant->>Viam: viam.capture_data
Viam-->>HomeAssistant: Data captured
User->>HomeAssistant: Request image capture
HomeAssistant->>Viam: viam.capture_image
Viam-->>HomeAssistant: Image captured
User->>HomeAssistant: Request classifications
HomeAssistant->>Viam: viam.get_classifications
Viam-->>HomeAssistant: Classifications retrieved
User->>HomeAssistant: Request detections
HomeAssistant->>Viam: viam.get_detections
Viam-->>HomeAssistant: Detections retrieved
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (1)
source/_integrations/viam.markdown (1)
18-18
: Consider a shorter alternative to avoid wordiness.The phrase "In order to use this integration" can be shortened to "To use this integration" for conciseness.
- In order to use this integration, you will need a [Viam account](https://www.viam.com/) and [a device with `viam-server` installed](https://docs.viam.com/installation/). + To use this integration, you will need a [Viam account](https://www.viam.com/) and [a device with `viam-server` installed](https://docs.viam.com/installation/).Tools
LanguageTool
[style] ~18-~18: Consider a shorter alternative to avoid wordiness.
Context: ...automation workflow. ## Prerequisites In order to use this integration, you will need a [...(IN_ORDER_TO_PREMIUM)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @HipsterBrown 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (1)
source/_integrations/viam.markdown (1)
17-19
: Consider a shorter alternative to avoid wordiness.The phrase "In order to use this integration" can be shortened to "To use this integration".
- In order to use this integration, you will need a [Viam account](https://www.viam.com/) and [a device with `viam-server` installed](https://docs.viam.com/installation/). + To use this integration, you will need a [Viam account](https://www.viam.com/) and [a device with `viam-server` installed](https://docs.viam.com/installation/).Tools
LanguageTool
[style] ~18-~18: Consider a shorter alternative to avoid wordiness.
Context: ...automation workflow. ## Prerequisites In order to use this integration, you will need a [...(IN_ORDER_TO_PREMIUM)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (1)
source/_integrations/viam.markdown (1)
17-19
: Consider a shorter alternative for "In order to".To avoid wordiness, consider using "To" instead of "In order to".
- In order to use this integration, you will need a [Viam account](https://www.viam.com/) and [a device with `viam-server` installed](https://docs.viam.com/installation/). + To use this integration, you will need a [Viam account](https://www.viam.com/) and [a device with `viam-server` installed](https://docs.viam.com/installation/).Tools
LanguageTool
[style] ~18-~18: Consider a shorter alternative to avoid wordiness.
Context: ...automation workflow. ## Prerequisites In order to use this integration, you will need a [...(IN_ORDER_TO_PREMIUM)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
source/_integrations/viam.markdown (3)
19-19
: Consider more concise wording.-In order to use this integration, you will need a [Viam account](https://www.viam.com/) and [a device with `viam-server` installed](https://docs.viam.com/installation/). +To use this integration, you will need a [Viam account](https://www.viam.com/) and [a device with `viam-server` installed](https://docs.viam.com/installation/).
27-75
: Consider documenting common parameters more consistently.The actions section is well-structured, but parameters like
filepath
andcamera
that appear in multiple actions could benefit from consistent descriptions. For example, inviam.capture_image
,filepath
is described as "Local file path to the image to be uploaded" while inviam.get_classifications
, it's "Local file path to the image to be analyzed".Consider standardizing these descriptions:
For filepath: -Local file path to the image to be uploaded. -Local file path to the image to be analyzed. +Local file path to the image file. For camera: -The camera entity from which an image is captured. -The camera entity from which an image is captured and analyzed. +The camera entity to capture the image from.
75-75
: Consider adding usage examples.The documentation would benefit from practical examples showing how to use these actions in Home Assistant automations. This would help users understand how to integrate Viam's capabilities into their smart home workflows.
Would you like me to help generate some example automation snippets?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
source/_integrations/viam.markdown
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/viam.markdown
[uncategorized] ~15-~15: You might be missing the article “the” here.
Context: ...tom machine learning models that run on device as part of your automation workflow. #...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
[style] ~18-~18: Consider a shorter alternative to avoid wordiness.
Context: ...automation workflow. ## Prerequisites In order to use this integration, you will need a [...
(IN_ORDER_TO_PREMIUM)
🔇 Additional comments (2)
source/_integrations/viam.markdown (2)
1-13
: LGTM! Frontmatter is well-structured.
The metadata is complete and follows Home Assistant's documentation standards.
15-15
: Add missing article "the" for grammatical correctness.
-The **Viam** {% term integrations %} allows you to turn your smart home into a smart machine! Use images and data from your Home Assistant setup to train custom machine learning models that run on device as part of your automation workflow.
+The **Viam** {% term integrations %} allows you to turn your smart home into a smart machine! Use images and data from your Home Assistant setup to train custom machine learning models that run on the device as part of your automation workflow.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~15-~15: You might be missing the article “the” here.
Context: ...tom machine learning models that run on device as part of your automation workflow. #...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
Proposed change
Add docs for integration with Viam.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
New Features
Documentation