Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Viam integration page #33925

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

HipsterBrown
Copy link
Contributor

@HipsterBrown HipsterBrown commented Jul 22, 2024

Proposed change

Add docs for integration with Viam.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • New Features

    • Introduced Viam integration for Home Assistant, allowing access to data and vision services.
    • Detailed documentation on prerequisites, authentication methods, and actions available through the integration.
    • Users can capture data and images, retrieve classifications, and send data for analysis.
  • Documentation

    • Comprehensive guide added for implementing and utilizing the Viam integration.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Jul 22, 2024
Copy link
Contributor

coderabbitai bot commented Jul 22, 2024

📝 Walkthrough

Walkthrough

A new documentation file, viam.markdown, has been introduced to provide comprehensive guidance on integrating Viam with Home Assistant. This integration allows users to access data and vision services via the Python SDK. The document includes prerequisites, authentication methods, and detailed descriptions of various actions users can perform, such as capturing data and images, and retrieving classifications and detections.

Changes

File Change Summary
source/_integrations/viam.markdown Added documentation for the Viam integration, covering prerequisites, authentication methods, and actions like data capture and image processing.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant HomeAssistant
    participant Viam

    User->>HomeAssistant: Initiate Viam integration
    HomeAssistant->>Viam: Authenticate using API key or secrets
    Viam-->>HomeAssistant: Authentication response
    User->>HomeAssistant: Request data capture
    HomeAssistant->>Viam: viam.capture_data
    Viam-->>HomeAssistant: Data captured
    User->>HomeAssistant: Request image capture
    HomeAssistant->>Viam: viam.capture_image
    Viam-->>HomeAssistant: Image captured
    User->>HomeAssistant: Request classifications
    HomeAssistant->>Viam: viam.get_classifications
    Viam-->>HomeAssistant: Classifications retrieved
    User->>HomeAssistant: Request detections
    HomeAssistant->>Viam: viam.get_detections
    Viam-->>HomeAssistant: Detections retrieved
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 4a29b27
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6729bcce039a4200080a5d65
😎 Deploy Preview https://deploy-preview-33925--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range, codebase verification and nitpick comments (1)
source/_integrations/viam.markdown (1)

18-18: Consider a shorter alternative to avoid wordiness.

The phrase "In order to use this integration" can be shortened to "To use this integration" for conciseness.

-  In order to use this integration, you will need a [Viam account](https://www.viam.com/) and [a device with `viam-server` installed](https://docs.viam.com/installation/).
+  To use this integration, you will need a [Viam account](https://www.viam.com/) and [a device with `viam-server` installed](https://docs.viam.com/installation/).
Tools
LanguageTool

[style] ~18-~18: Consider a shorter alternative to avoid wordiness.
Context: ...automation workflow. ## Prerequisites In order to use this integration, you will need a [...

(IN_ORDER_TO_PREMIUM)

@c0ffeeca7 c0ffeeca7 added the new-integration This PR adds documentation for a new Home Assistant integration label Jul 23, 2024
c0ffeeca7
c0ffeeca7 previously approved these changes Jul 23, 2024
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @HipsterBrown 👍

@c0ffeeca7 c0ffeeca7 added the awaits-parent Awaits the merge of an parent PR label Jul 23, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range, codebase verification and nitpick comments (1)
source/_integrations/viam.markdown (1)

17-19: Consider a shorter alternative to avoid wordiness.

The phrase "In order to use this integration" can be shortened to "To use this integration".

- In order to use this integration, you will need a [Viam account](https://www.viam.com/) and [a device with `viam-server` installed](https://docs.viam.com/installation/).
+ To use this integration, you will need a [Viam account](https://www.viam.com/) and [a device with `viam-server` installed](https://docs.viam.com/installation/).
Tools
LanguageTool

[style] ~18-~18: Consider a shorter alternative to avoid wordiness.
Context: ...automation workflow. ## Prerequisites In order to use this integration, you will need a [...

(IN_ORDER_TO_PREMIUM)

source/_integrations/viam.markdown Outdated Show resolved Hide resolved
c0ffeeca7
c0ffeeca7 previously approved these changes Jul 23, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range, codebase verification and nitpick comments (1)
source/_integrations/viam.markdown (1)

17-19: Consider a shorter alternative for "In order to".

To avoid wordiness, consider using "To" instead of "In order to".

-  In order to use this integration, you will need a [Viam account](https://www.viam.com/) and [a device with `viam-server` installed](https://docs.viam.com/installation/).
+  To use this integration, you will need a [Viam account](https://www.viam.com/) and [a device with `viam-server` installed](https://docs.viam.com/installation/).
Tools
LanguageTool

[style] ~18-~18: Consider a shorter alternative to avoid wordiness.
Context: ...automation workflow. ## Prerequisites In order to use this integration, you will need a [...

(IN_ORDER_TO_PREMIUM)

source/_integrations/viam.markdown Outdated Show resolved Hide resolved
source/_integrations/viam.markdown Outdated Show resolved Hide resolved
source/_integrations/viam.markdown Outdated Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (3)
source/_integrations/viam.markdown (3)

19-19: Consider more concise wording.

-In order to use this integration, you will need a [Viam account](https://www.viam.com/) and [a device with `viam-server` installed](https://docs.viam.com/installation/).
+To use this integration, you will need a [Viam account](https://www.viam.com/) and [a device with `viam-server` installed](https://docs.viam.com/installation/).

27-75: Consider documenting common parameters more consistently.

The actions section is well-structured, but parameters like filepath and camera that appear in multiple actions could benefit from consistent descriptions. For example, in viam.capture_image, filepath is described as "Local file path to the image to be uploaded" while in viam.get_classifications, it's "Local file path to the image to be analyzed".

Consider standardizing these descriptions:

For filepath:
-Local file path to the image to be uploaded.
-Local file path to the image to be analyzed.
+Local file path to the image file.

For camera:
-The camera entity from which an image is captured.
-The camera entity from which an image is captured and analyzed.
+The camera entity to capture the image from.

75-75: Consider adding usage examples.

The documentation would benefit from practical examples showing how to use these actions in Home Assistant automations. This would help users understand how to integrate Viam's capabilities into their smart home workflows.

Would you like me to help generate some example automation snippets?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between abf2605 and 4a29b27.

📒 Files selected for processing (1)
  • source/_integrations/viam.markdown (1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/viam.markdown

[uncategorized] ~15-~15: You might be missing the article “the” here.
Context: ...tom machine learning models that run on device as part of your automation workflow. #...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


[style] ~18-~18: Consider a shorter alternative to avoid wordiness.
Context: ...automation workflow. ## Prerequisites In order to use this integration, you will need a [...

(IN_ORDER_TO_PREMIUM)

🔇 Additional comments (2)
source/_integrations/viam.markdown (2)

1-13: LGTM! Frontmatter is well-structured.

The metadata is complete and follows Home Assistant's documentation standards.


15-15: Add missing article "the" for grammatical correctness.

-The **Viam** {% term integrations %} allows you to turn your smart home into a smart machine! Use images and data from your Home Assistant setup to train custom machine learning models that run on device as part of your automation workflow.
+The **Viam** {% term integrations %} allows you to turn your smart home into a smart machine! Use images and data from your Home Assistant setup to train custom machine learning models that run on the device as part of your automation workflow.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~15-~15: You might be missing the article “the” here.
Context: ...tom machine learning models that run on device as part of your automation workflow. #...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants