http: check for OP_NO_COMPRESSION support before trying to use it #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks 🐬 I will issue a hotfix with this included. |
balloob
pushed a commit
that referenced
this pull request
Jul 2, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR changes the http component to only use ssl.OP_NO_COMPRESSION if ssl.py has support for it. Apparently MacOS has an old Python and/or OpenSSL where it is not supported, preventing HASS startup.
cc @danieljkemp
Related issue (if applicable):
Should fix https://home-assistant.io/blog/2016/07/01/envisalink-homematic-hdmi-cec-and-sony-bravia-tv/#comment-2761211326 (but I don't have a mac to test in the wild, and as of this writing version details were not reported)
toxrun successfully. Your PR cannot be merged unless tests pass