Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgraded pubnub version #2420

Merged
merged 1 commit into from
Jul 2, 2016
Merged

Conversation

w1ll1am23
Copy link
Contributor

@w1ll1am23 w1ll1am23 commented Jul 2, 2016

Description:
Downgrade the pubnub version prior to when they started using pycryptodome.

Related issue (if applicable): fixes #2411

Checklist:

If code communicates with devices, web services, or a:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@balloob balloob merged commit 2b51413 into home-assistant:dev Jul 2, 2016
balloob pushed a commit that referenced this pull request Jul 2, 2016
@balloob
Copy link
Member

balloob commented Jul 4, 2016

The problem with this change is that now it works on Linux but it no longer works on Windows 10.

What would be a good way of resolving this ?

@w1ll1am23
Copy link
Contributor Author

w1ll1am23 commented Jul 4, 2016

I never had an issue with the newer version of pubnub in Linux. Is there
another component that requires pycrypto? They only people I saw that
reported an issue with the original version were people using docker, can
something be changed in docker?

Will pycryptodome work in Windows 10? Or will they have the same problem.

I believe @RandomActPG got the current version working in Windows (not sure what version) by running this https://github.com/axper/python3-pycrypto-windows-installer

On Jul 4, 2016 12:42 PM, "Paulus Schoutsen" [email protected]
wrote:

The problem with this change is that now it works on Linux but it no
longer works on Windows 10.

What would be a good way of resolving this ?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2420 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AGIoAjMPbBQraGazVGp2p1xH-GzwA2k9ks5qSTf-gaJpZM4JDsIs
.

@balloob
Copy link
Member

balloob commented Jul 4, 2016

The only thing that the Docker image does is that it installs all the requirements at once. I wouldn't be surprised if somewhere something depends on pycrypto.

@RandomActPG
Copy link

BTW I used that installer on Windows 10 64-bit.

trying to install the usual way resulted in an error when it was unable to find C++ 10.0 even though it was installed.

@w1ll1am23
Copy link
Contributor Author

w1ll1am23 commented Jul 4, 2016

I received a reply from pubnub. Based on their response I think it would
be best to switch to their reduced crypto branch. This doesn't have any
crypto dependencies so it should work on all platforms. They also mention
switching to cryptography.io witch appears to work in Windows, but not sure
when they will be done with that. Pubnub response is below.

" cryptography.io is the library we are going to use for PubNub Python SDK
v4, we have scoped this as one of the dependencies. The exact timeline for
v4 is still in the works but we hope to start seeding the first beta in the
next month or so.

For the reduce_crypto branch (a version of the SDK with no encryption
library dependency), the ssl_on and cryptography are two separate features.
ssl_on ensures that the client communicates to PubNub via https://
protocol, while the cryptography dependency is required to encrypt the
actual payload of the published messages and is activated only if you are
passing a cipher_key."
On Jul 4, 2016 12:50 PM, "william scanlon" [email protected] wrote:

I never had an issue with the newer version of pubnub in Linux. Is there
another component that requires pycrypto? They only people I saw that
reported an issue with the original version were people using docker, can
something be changed in docker?
On Jul 4, 2016 12:42 PM, "Paulus Schoutsen" [email protected]
wrote:

The problem with this change is that now it works on Linux but it no
longer works on Windows 10.

What would be a good way of resolving this ?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2420 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AGIoAjMPbBQraGazVGp2p1xH-GzwA2k9ks5qSTf-gaJpZM4JDsIs
.

@w1ll1am23 w1ll1am23 mentioned this pull request Jul 14, 2016
2 tasks
@w1ll1am23 w1ll1am23 deleted the downgrade_pubnub branch November 22, 2016 21:07
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wink/Pubnub dependency issue
3 participants