Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homematic fix #2399

Merged
merged 5 commits into from
Jun 30, 2016
Merged

Homematic fix #2399

merged 5 commits into from
Jun 30, 2016

Conversation

pvizeli
Copy link
Member

@pvizeli pvizeli commented Jun 30, 2016

Description:

  • Add support for WaterSensor
  • Fix bug with keypress event and channel

If user exposed functionality or configuration variables are added/changed:

If code communicates with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@pvizeli pvizeli merged commit a57cd58 into home-assistant:dev Jun 30, 2016
@pvizeli pvizeli deleted the Homematic_fix branch June 30, 2016 22:17
@balloob
Copy link
Member

balloob commented Jun 30, 2016

You shouldn't work in your dev branch on your repo but instead fork off it to avoid the merge commits. Also, when you merge your PR, squash the commits so that we don't get those merge commits in our dev branch ;-)

@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants