kodi platform: following jsonrpc-request version bump (0.3), let kodi… #2398
Conversation
… file abstraction layer handle a collection item, url or file to play
| @@ -301,4 +301,4 @@ def media_seek(self, position): | |||
|
|
|||
| def play_media(self, media_type, media_id, **kwargs): | |||
| """Send the play_media command to the media player.""" | |||
| self._server.Player.Open({media_type: media_id}, {}) | |||
| self._server.Player.Open({"item": {"file": str(media_id)}}) | |||
There was a problem hiding this comment.
You are now hardcoding media_type to be file instead of allowing the user to specify it. Does Kodi have any other media types?
There was a problem hiding this comment.
Kodi's files api doesn't need a media type to be specified, just a path, should it be an url ("http://myfavoritewebcast.xyz:9999") or any reachable path actually ("plugin://plugin.video.youtube/?action=play_video&videoid=VWu5FAJrUpQ", "nfs://" and "smb://" included).
One might definitely be in need for the media_type when implementing ATTR_MEDIA_ENQUEUE as kodi seems to offer media-type dedicated queues/playlists but must come with a plan and/or tests first.
Please have a look at http://kodi.wiki/view/JSON-RPC_API/#Player.Open for interesting specs and http://kodi.wiki/view/JSON-RPC_API/Examples for playful reference ... 😊 from the first example, given an instance and curl, I find the result of this cmdline very readable:
curl -s -H "Content-type: application/json" -d '{"jsonrpc":"2.0","method":"JSONRPC.Introspect", "params":{"filter":{ "id": "Player.Open", "type": "method" } }, "id": 1 }' http://kodi.local/jsonrpc | python -mjson.tool | pygmentize -f terminal256 -l javascriptI'm totally amazed, blasted! by both kodi and ha and I'd love to elaborate more on the platform, especially collaboratively ...
|
Looks good! 🐬 |
ghost
deleted the
Description:
Hand over the collection item, the url or the file to play directly to kodi's file abstraction layer
Related issue (if applicable): fixes #
fixes kodi platform's implementation of media_player.play_media()
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If code communicates with devices:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass