Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonrpc-request version bump (0.3) #2397

Merged
merged 1 commit into from Jun 30, 2016
Merged

jsonrpc-request version bump (0.3) #2397

merged 1 commit into from Jun 30, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jun 30, 2016

Description:
Better RFC compliance, allows passing dict as single object parameter to the request.

Related issue (if applicable): fixes #
Enhances kodi platform efficiency and its future development

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

If code communicates with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@balloob balloob merged commit 7582eb9 into home-assistant:dev Jun 30, 2016
@balloob
Copy link
Member

balloob commented Jun 30, 2016

Thanks 🐬

@ghost ghost deleted the jsonrpc_request_version_bump_0_3 branch July 1, 2016 01:19
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant