vera lock support #2391
Merged
vera lock support #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def update(self): | ||
| """Called by the vera device callback to update state.""" | ||
| self._state = STATE_LOCKED if self.vera_device.is_locked(True) else STATE_UNLOCKED |
There was a problem hiding this comment.
- 80: E501 line too long (90 > 79 characters)
| def device_state_attributes(self): | ||
| """Return the state attributes of the device.""" | ||
| attr = {} | ||
| if self.vera_device.has_battery: |
There was a problem hiding this comment.
Shouldn't these be generalized inside VeraDevice ?
|
The code looks fine. I've added some small improvements. I'll merge this now but you can create a new PR if you feel like addressing those 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add Vera Lock support using pyvera 0.2.12
Related issue (if applicable): fixes #603
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#598
Checklist:
If user exposed functionality or configuration variables are added/changed:
If code communicates with devices:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass