Depreciate ssl2/3 #2375
Merged
Depreciate ssl2/3 #2375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the best practices as defind here: https://mozilla.github.io/server-side-tls/ssl-config-generator/
| @@ -36,6 +37,22 @@ | |||
|
|
|||
| DATA_API_PASSWORD = 'api_password' | |||
|
|
|||
| # https://mozilla.github.io/server-side-tls/ssl-config-generator/ | |||
There was a problem hiding this comment.
Could you add to the comment that it's the intermediate settings?
added 2 commits
June 26, 2016 13:21
Links to the rational rather than the config generator; explains link.
|
Awesome! 🐬 |
1 task
|
Could be a platform specific bug, I don't have a Mac to test it on, and won't be able to look at anything before Sunday. @AlucardZero could you take a look maybe? This could be hotfix worthy if ssl broke for Mac users. |
|
ssl.OP_NO_COMPRESSION came with Python 3.3, and Home Assistant requires 3.4, so, probably the user needs to fix his Python? I don't have a Mac either. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Depreciate sslv2 and sslv3
Related issue (if applicable): fixes #2364
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#
Example entry for
configuration.yaml(if applicable):As discussed this is not configurable. It should work with anything made in the last 10 years.
Checklist:
If user exposed functionality or configuration variables are added/changed:
If code communicates with devices:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests passFollowing the best practices as defind here:
https://mozilla.github.io/server-side-tls/ssl-config-generator/