Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lxml dependency #2374

Merged
merged 1 commit into from
Jun 26, 2016
Merged

Remove lxml dependency #2374

merged 1 commit into from
Jun 26, 2016

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jun 26, 2016

Description:
Remove the lxml dependency.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: swiss_hydrological_data
    name: Aare
    station: 2135

Checklist:

If user exposed functionality or configuration variables are added/changed:

If code communicates with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@balloob
Copy link
Member

balloob commented Jun 26, 2016

Thanks! :🐬

@balloob balloob merged commit 254b1c4 into home-assistant:dev Jun 26, 2016
@fabaff fabaff deleted the hydro-xml branch June 26, 2016 17:58
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants