-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homematic Support #2366
Closed
Closed
Homematic Support #2366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix REQUIREMENTS handling
self._state) | ||
self._data.update({self._state: STATE_UNKNOWN}) | ||
|
||
def _create_binary_list_from_hm(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- D210: No whitespaces allowed surrounding docstring text
- D400: First line should end with a period (not 'r')
https://github.com/danielperna84/home-assistant/pull/11 will fix all docstyle issue |
fix docstring & remove unwanted code from autodetect
update requirements
We have fix all errors from our new modul. All other fails are from HA core... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding bi-directional Homematic support. This includes lots of actors (switches, rollershutters etc.), thermostats and sensors (motion, brightness, shutter contacts etc.). I roughly estimate that we cover more than 60% (maybe even more) of all the currently available Homematic RF products, which are widely spread in Europe (primarily Germany, Austria and Switzerland).
Configuration of devices might be complex, but we'll cover that in the documentation (working on that). Basic setup is described within the component/platform files.
We also have an (experimental) autodetect feature, which discovers and configures every device we're capable of handling, although without friendly names. But for beginners this will quickly show which of their devices are supported and can be manually configured accordingly.
Thanks to @jazzaj for starting the Homematic implementation based on my pyhomematic module.
Thanks to @pvizeli for making radical improvements to my module and jazzajs implementation.
Thanks to @bimbar for support of MAX! Thermostats.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#
Example entry for
configuration.yaml
(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If code communicates with devices:
tox
run successfully. Your PR cannot be merged unless tests passREQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.