Add support for wind, battery, radio signals for Netatmo sensor #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,6 +24,15 @@ | |||
| 'rain': ['Rain', 'mm', 'mdi:weather-rainy'], | |||
| 'sum_rain_1': ['sum_rain_1', 'mm', 'mdi:weather-rainy'], | |||
| 'sum_rain_24': ['sum_rain_24', 'mm', 'mdi:weather-rainy'], | |||
| 'battery_vp': ['Battery','','mdi:battery'], | |||
There was a problem hiding this comment.
- 30: E231 missing whitespace after ','
- 33: E231 missing whitespace after ','
|
Add |
Danielhiversen
changed the title
|
Thanks @fabaff! |
| @@ -11,19 +11,31 @@ | |||
| from homeassistant.util import Throttle | |||
| from homeassistant.loader import get_component | |||
|
|
|||
| # Fix for pylint too many statements error | |||
| # pylint: disable=too-many-statements | |||
There was a problem hiding this comment.
You shouldn't add this here at the top of the module, but local where the problem is. Put it on the next row directly after the docstring in the update method, near row 109. The disable statement has scope, so it's best to disable as little as possible, and it also makes it easier to see why it was needed.
The update method could be refactored to avoid the disable. It might be out of scope for this PR, but I would do a nested dict lookup and have a function that checks if data value is above inner dict value.
|
Looks good 🐬 💨 |
|
Perfect! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If code communicates with devices:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass