add reload core config service #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def test_turn_on_without_entities(self): | ||
| """Test turn_on method without entities.""" | ||
| runs = [] | ||
| self.hass.services.register( |
There was a problem hiding this comment.
Can't you use the mock service register function in test common?
|
Looks good! One comment/question. |
balloob
force-pushed
the
reload-customize
branch
from
55d2784 to
dd59061
Compare
|
Thanks for the code review. But, no 🐬 ?? |
balloob
force-pushed
the
reload-customize
branch
from
dd59061 to
e91cc81
Compare
balloob
force-pushed
the
reload-customize
branch
from
e91cc81 to
f069d6a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add a new service
homeassistant/reload_core_configwhich will reload the[homeassistant]part ofconfiguration.yaml(which includescustomize) and applies it.Changes to customize attributes on entities will not be reflected until the next time that related entities update.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#
Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass