Add support for Fixer.io #2336
Merged
Add support for Fixer.io #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.data.update() | ||
| self._state = round(self.data.rate['rates'][self._target], 3) | ||
|
|
||
| class ExchangeData(object): |
There was a problem hiding this comment.
- 1: E302 expected 2 blank lines, found 1
|
It's amazing that you can accomplish this in less than an hour and I spent days getting nowhere with it :) BTW, Fixer updates the currencies only once a day. Whereas the others (Currencylayer and Openexchangerates) update their rates hourly. It will be nice if can you take the code that I have for the other two sensors and create the components for them (I wish I knew how to get the |
|
It's true that fixer.io is not the best source if you want to follow the trend of exchange rates closely. |
|
|
||
|
|
||
| # pylint: disable=too-few-public-methods | ||
| class ExchangeRateSensor(Entity): |
There was a problem hiding this comment.
Shouldn't unit_of_measurement be self._target ? That way you can get a graph
|
🐬 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There seems to be a demand for exchange rate sensors (eg. Currencylayer and #2310). Fixer.io doesn't require an API key and allows unlimited requests (for now).
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#574
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If code communicates with devices:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass