Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for hydrological data from FOEN #2318

Merged
merged 1 commit into from
Jun 18, 2016
Merged

Add support for hydrological data from FOEN #2318

merged 1 commit into from
Jun 18, 2016

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jun 17, 2016

Description:
The swiss_hydrological_data sensor display the current water temperature (and more as ATTR) of a given measuring point which are located at Swiss rivers and lakes.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#566

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: swiss_hydrological_data
    name: Aare
    station: 2030

Checklist:

If user exposed functionality or configuration variables are added/changed:

If code communicates with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

CONF_STATION = 'station'
ICON = 'mdi:cup-water'

ATTR_DISCHARGE = 'Discharge'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those shoud be STATE_ATTR_*

@balloob
Copy link
Member

balloob commented Jun 18, 2016

Looks good! 🐬

@balloob balloob merged commit 28d8620 into home-assistant:dev Jun 18, 2016
for cell in cells:
details.append(cell.string)

self.measurings = HydroData._make(details)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to use HydroData(details) but this will work too

@fabaff fabaff deleted the hydro-data branch June 22, 2016 12:08
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants